Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Variant Lineage #1096

Merged
merged 13 commits into from
Oct 20, 2023
Merged

Source Variant Lineage #1096

merged 13 commits into from
Oct 20, 2023

Conversation

anthonylasso
Copy link
Contributor

@anthonylasso anthonylasso commented Oct 18, 2023

Description

This PR allows the user to visit a source variants input lineage directly from the entity page.
Each input will be listed in a name:variant format.

docker - sql

Screenshot 2023-10-18 at 10 38 11 AM

localmode - dataframe
Screenshot 2023-10-18 at 2 30 47 PM

video example

Screen.Recording.2023-10-18.at.10.54.22.AM.mov

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #1096 (125128c) into main (3882edb) will decrease coverage by 5.21%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1096      +/-   ##
==========================================
- Coverage   39.53%   34.33%   -5.21%     
==========================================
  Files         115      116       +1     
  Lines       21784    21877      +93     
==========================================
- Hits         8612     7511    -1101     
- Misses      12675    14114    +1439     
+ Partials      497      252     -245     
Files Coverage Δ
client/src/featureform/dashboard_metadata.py 80.43% <100.00%> (+0.23%) ⬆️
client/src/featureform/metadata_repository.py 86.00% <100.00%> (+0.28%) ⬆️
client/src/featureform/resources.py 76.25% <100.00%> (ø)
client/src/featureform/type_objects.py 82.60% <ø> (ø)
metadata/metadata.go 67.40% <ø> (-2.92%) ⬇️

... and 29 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ahmadnazeri
Copy link
Contributor

does it make sense to make the link name.variant instead of name:variant?

@anthonylasso anthonylasso temporarily deployed to Integration testing October 18, 2023 23:00 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing October 18, 2023 23:00 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing October 19, 2023 22:38 — with GitHub Actions Inactive
@anthonylasso anthonylasso merged commit 7862d27 into main Oct 20, 2023
21 of 42 checks passed
@anthonylasso anthonylasso deleted the feature/143/lineage branch October 20, 2023 00:29
sdreyer pushed a commit that referenced this pull request Oct 25, 2023
RiddhiBagadiaa pushed a commit that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants