Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flask compatibility with python 3.7 #1111

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

sdreyer
Copy link
Collaborator

@sdreyer sdreyer commented Oct 19, 2023

Description

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@sdreyer sdreyer temporarily deployed to Integration testing October 19, 2023 22:03 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing October 19, 2023 22:03 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #1111 (46bf06d) into main (3bebf40) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1111      +/-   ##
==========================================
- Coverage   39.34%   39.26%   -0.08%     
==========================================
  Files         114      115       +1     
  Lines       21399    21784     +385     
==========================================
+ Hits         8419     8554     +135     
- Misses      12507    12746     +239     
- Partials      473      484      +11     

see 21 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sdreyer sdreyer requested a review from aolfat October 19, 2023 22:14
@sdreyer sdreyer merged commit 3882edb into main Oct 19, 2023
34 of 42 checks passed
@sdreyer sdreyer deleted the bugfix/fix-compatibility-with-python-3.7 branch October 19, 2023 22:17
sdreyer added a commit that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants