Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: ability to get spark data frames for training sets #1121

Merged
merged 24 commits into from
Oct 31, 2023
Merged

Feature: ability to get spark data frames for training sets #1121

merged 24 commits into from
Oct 31, 2023

Conversation

ahmadnazeri
Copy link
Contributor

Description

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 23, 2023 16:13 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 23, 2023 16:14 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 23, 2023 16:14 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 23, 2023 16:14 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 23, 2023 16:14 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 23, 2023 17:04 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 23, 2023 17:04 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 23, 2023 17:04 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri marked this pull request as ready for review October 23, 2023 17:15
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 23, 2023 17:17 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 23, 2023 17:17 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 23, 2023 17:17 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 23, 2023 17:17 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 23, 2023 17:17 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 30, 2023 17:42 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 30, 2023 17:42 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 30, 2023 17:42 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 30, 2023 17:42 — with GitHub Actions Inactive
sdreyer
sdreyer reviewed Oct 30, 2023
View reviewed changes
client/src/featureform/enums.py Show resolved Hide resolved
serving/serving.go Show resolved Hide resolved
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 30, 2023 19:48 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 30, 2023 19:48 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 30, 2023 19:48 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 30, 2023 19:48 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 30, 2023 19:48 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 30, 2023 19:48 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 30, 2023 21:18 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 30, 2023 21:18 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 30, 2023 21:18 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 30, 2023 21:18 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 30, 2023 21:18 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 30, 2023 21:18 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 31, 2023 00:30 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 31, 2023 00:30 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 31, 2023 00:30 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 31, 2023 00:30 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 31, 2023 00:30 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing October 31, 2023 00:31 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri merged commit 681080c into main Oct 31, 2023
39 checks passed
@ahmadnazeri ahmadnazeri deleted the feature/spark_get_training_set branch October 31, 2023 05:27
RiddhiBagadiaa pushed a commit that referenced this pull request Nov 16, 2023
@ahmadnazeri @RiddhiBagadiaa
Feature: ability to get spark data frames for training sets (#1121)
189f76a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aolfat aolfat aolfat left review comments

@sdreyer sdreyer sdreyer approved these changes

@epps epps Awaiting requested review from epps

@anthonylasso anthonylasso Awaiting requested review from anthonylasso

@RiddhiBagadiaa RiddhiBagadiaa Awaiting requested review from RiddhiBagadiaa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahmadnazeri @aolfat @sdreyer