Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Preview Charts #1129

Merged
merged 32 commits into from
Nov 1, 2023
Merged

Feature Preview Charts #1129

merged 32 commits into from
Nov 1, 2023

Conversation

anthonylasso
Copy link
Contributor

@anthonylasso anthonylasso commented Oct 27, 2023 •
edited

Description

This PR will allow users to preview feature data within the feature page, as well as visualize the column stats with summary charts.

closes https://github.com/featureform/featureform-enterprise/issues/324

preview example
Screenshot 2023-10-30 at 11 12 07 AM

go tests
Screenshot 2023-10-30 at 6 56 15 PM

jest tests
Screenshot 2023-10-29 at 6 45 25 PM

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@anthonylasso anthonylasso changed the title Feature Preview Charts ent-340 Feature Preview Charts Oct 27, 2023
@anthonylasso anthonylasso temporarily deployed to Integration testing October 27, 2023 15:50 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing October 27, 2023 15:50 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing October 27, 2023 15:59 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing October 27, 2023 15:59 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing October 27, 2023 15:59 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing October 27, 2023 15:59 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing October 27, 2023 16:26 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing October 31, 2023 17:16 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing October 31, 2023 17:16 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing October 31, 2023 17:16 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing October 31, 2023 17:16 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing October 31, 2023 17:16 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing October 31, 2023 18:51 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing October 31, 2023 18:51 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing October 31, 2023 18:51 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing October 31, 2023 18:51 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing October 31, 2023 18:51 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing October 31, 2023 18:51 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing November 1, 2023 00:00 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing November 1, 2023 00:00 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing November 1, 2023 00:00 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing November 1, 2023 00:00 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing November 1, 2023 00:00 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing November 1, 2023 04:14 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing November 1, 2023 04:14 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing November 1, 2023 04:14 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing November 1, 2023 04:14 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing November 1, 2023 04:14 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing November 1, 2023 04:14 — with GitHub Actions Inactive
@sdreyer sdreyer merged commit 4706520 into main Nov 1, 2023
36 checks passed
@sdreyer sdreyer deleted the feature/324/charts branch November 1, 2023 06:23
RiddhiBagadiaa pushed a commit that referenced this pull request Nov 16, 2023
@anthonylasso @sdreyer
@ahmadnazeri @RiddhiBagadiaa
Feature Preview Charts (#1129)
e500b36 
Co-authored-by: sdreyer <sterling@featureform.com>
Co-authored-by: ahmadnazeri <42309296+ahmadnazeri@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdreyer sdreyer sdreyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anthonylasso @sdreyer @ahmadnazeri