Databricks/client creds input validation #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
file: client/src/featureform/resources.py change logs: Inside DatabricksCredentials Class - add @DataClass and __post_init__ - _validate_cluster_id and _validate_token regex validation for cluster_id and token
File: client/tests/test_executor_resources.py Cases covered: - valid token and cluster id - cluster id and token are empty - have incorrect format or invalid characters
Why? Now that we have cluster_id validator we need to use right format for cluster id.
file: client/tests/conftest.py
change logs:
def databricks():
return DatabricksCredentials(
username="a", password="b", cluster_id="abc-123def-ghijklmn"
)
AND
def spark_provider(ff_registrar):
databricks = DatabricksCredentials(
username="a", password="b", cluster_id="abc-123def-ghijklmn"
)
azure_blob = AzureFileStoreConfig(
account_name="", account_key="", container_name="", root_path=""
)
updates: Now the regex pattern will exactly match the following pattern dapixxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx-x
sdreyer
approved these changes
Nov 21, 2023
sdreyer
had a problem deploying
to
Integration testing
GitHub Actions
Failure
sdreyer
had a problem deploying
to
Integration testing
GitHub Actions
Failure
sdreyer
had a problem deploying
to
Integration testing
GitHub Actions
Failure
sdreyer
had a problem deploying
to
Integration testing
GitHub Actions
Failure
sdreyer
had a problem deploying
to
Integration testing
GitHub Actions
Failure
sdreyer
had a problem deploying
to
Integration testing
GitHub Actions
Failure
sdreyer
had a problem deploying
to
Integration testing
GitHub Actions
Failure
ihkap11
had a problem deploying
to
Integration testing
GitHub Actions
Failure
ihkap11
had a problem deploying
to
Integration testing
GitHub Actions
Failure
ihkap11
had a problem deploying
to
Integration testing
GitHub Actions
Failure
ihkap11
had a problem deploying
to
Integration testing
GitHub Actions
Failure
ihkap11
had a problem deploying
to
Integration testing
GitHub Actions
Failure
ihkap11
had a problem deploying
to
Integration testing
GitHub Actions
Failure
ihkap11
had a problem deploying
to
Integration testing
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add validators for Databricks credentials - token id and cluster id, to ensure proper format to avoid confusion with users.
Tests failing before:
===== 104 failed, 383 passed, 14 xfailed, 227 warnings, 5 errors in 45.88s =====Tests failing after:
===== 103 failed, 384 passed, 19 xfailed, 227 warnings, 5 errors in 45.81s =====Issue: #1143
Enhancement
Does this correspond to an open issue?
Select type(s) of change
Checklist: