-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I 1155/feature/searchable premade tags #1167
Merged
sdreyer
merged 23 commits into
featureform:main
from
ihkap11:i-1155/feature/searchable_premade_tags
Jan 18, 2024
Merged
I 1155/feature/searchable premade tags #1167
sdreyer
merged 23 commits into
featureform:main
from
ihkap11:i-1155/feature/searchable_premade_tags
Jan 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihkap11
commented
Nov 21, 2023
func: func (wrapper SearchWrapper) Set(id ResourceID, res Resource) Idea: Check if res is of a given variant resource type, extract tags, and use it to build ResourceDoc
epps
reviewed
Jan 8, 2024
epps
reviewed
Jan 8, 2024
anthonylasso
reviewed
Jan 9, 2024
This is great, thanks for the effort! Resolve the comments at will and we'll approve. |
anthonylasso
approved these changes
Jan 11, 2024
anthonylasso
temporarily deployed
to
Integration testing
January 11, 2024 18:22
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
January 11, 2024 18:22
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
January 11, 2024 18:22
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
January 11, 2024 18:22
— with
GitHub Actions
Inactive
anthonylasso
had a problem deploying
to
Integration testing
January 11, 2024 18:23
— with
GitHub Actions
Failure
anthonylasso
temporarily deployed
to
Integration testing
January 11, 2024 18:23
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
January 11, 2024 18:23
— with
GitHub Actions
Inactive
anthonylasso
had a problem deploying
to
Integration testing
January 11, 2024 18:23
— with
GitHub Actions
Failure
ihkap11
had a problem deploying
to
Integration testing
January 11, 2024 18:25
— with
GitHub Actions
Failure
ihkap11
had a problem deploying
to
Integration testing
January 11, 2024 18:25
— with
GitHub Actions
Failure
ihkap11
had a problem deploying
to
Integration testing
January 11, 2024 18:25
— with
GitHub Actions
Failure
ihkap11
had a problem deploying
to
Integration testing
January 11, 2024 18:25
— with
GitHub Actions
Failure
ihkap11
had a problem deploying
to
Integration testing
January 11, 2024 18:25
— with
GitHub Actions
Failure
ihkap11
had a problem deploying
to
Integration testing
January 11, 2024 18:25
— with
GitHub Actions
Failure
ihkap11
had a problem deploying
to
Integration testing
January 11, 2024 18:25
— with
GitHub Actions
Failure
ihkap11
had a problem deploying
to
Integration testing
January 11, 2024 18:25
— with
GitHub Actions
Failure
11 tasks
epps
pushed a commit
that referenced
this pull request
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make pre-made tags searchable.
Task 1: Premade tags should be searchable (
metadata
)ResourceDoc
is the structure that can expose Tags as a searchable parameter for Meilisearch.search_test.go
Task 2: New tags added to resource should be searchable (from
metadata dashboard
)Recording.2023-12-20.135356.mp4
Type of change
Feature
Does this correspond to an open issue?
#1155
Select type(s) of change
Checklist: