Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I 1155/feature/searchable premade tags #1167

Merged

Conversation

ihkap11
Copy link
Contributor

@ihkap11 ihkap11 commented Nov 21, 2023

Description

Make pre-made tags searchable.

Task 1: Premade tags should be searchable (metadata)

  • ResourceDoc is the structure that can expose Tags as a searchable parameter for Meilisearch.
  • Test strategy: Using personal tokens for running Meilisearch locally, and testing through search_test.go
    image

Task 2: New tags added to resource should be searchable (from metadata dashboard)

  • PostTags allows updating variant resource's tags.
  • Updating resources in the Meilisearch resource index makes the newly introduced tags appear in search results.
  • Test Strategy:
Recording.2023-12-20.135356.mp4

Type of change

Feature

Does this correspond to an open issue?

#1155

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

metadata/metadata.go Outdated Show resolved Hide resolved
@ihkap11 ihkap11 marked this pull request as ready for review December 19, 2023 17:47
func: func (wrapper SearchWrapper) Set(id ResourceID, res Resource)

Idea: Check if res is of a given variant resource type, extract tags, and use it to build ResourceDoc
metadata/metadata.go Outdated Show resolved Hide resolved
metadata/metadata.go Outdated Show resolved Hide resolved
@anthonylasso
Copy link
Contributor

This is great, thanks for the effort! Resolve the comments at will and we'll approve.

@anthonylasso
Copy link
Contributor

Passing CI/CD in a separate branch. Will merge commit the unit test fix into this one.

Screenshot 2024-01-12 at 2 05 47 PM

@anthonylasso anthonylasso mentioned this pull request Jan 13, 2024
11 tasks
@sdreyer sdreyer merged commit 094622f into featureform:main Jan 18, 2024
github-actions bot pushed a commit that referenced this pull request Jan 18, 2024
epps pushed a commit that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants