Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register batch features #1195

Merged
merged 34 commits into from
Dec 13, 2023
Merged

Register batch features #1195

merged 34 commits into from
Dec 13, 2023

Conversation

RiddhiBagadiaa
Copy link
Contributor

Description

Introduce ff.MultiFeature which registers multiple features through one function call. The user can register certain features using the included_columns argument or register all but a few features using the excluded_columns argument.

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

ahmadnazeri
ahmadnazeri reviewed Dec 4, 2023
View reviewed changes
client/src/featureform/register.py Outdated Show resolved Hide resolved
client/src/featureform/register.py Outdated Show resolved Hide resolved
client/src/featureform/register.py Outdated Show resolved Hide resolved
client/src/featureform/register.py Outdated Show resolved Hide resolved
tests/end_to_end/features/steps/multifeature_registration.py Outdated Show resolved Hide resolved
tests/end_to_end/features/steps/multifeature_registration.py Outdated Show resolved Hide resolved
@aolfat
Copy link
Contributor

aolfat commented Dec 6, 2023 •
edited

It'll be good to leverage chat gpt to help clean up some of your code + modularize it into separate functions + make it more readable, this is what I use sometimes before I open a PR: https://chat.openai.com/g/g-qiridIddk-code-mentor.

@anthonylasso
Copy link
Contributor

in case you haven't already, definitely want to install Black Formatter plugin. I have mine set to format on save, super useful.

@RiddhiBagadiaa RiddhiBagadiaa merged commit 3d80840 into main Dec 13, 2023
43 checks passed
@RiddhiBagadiaa RiddhiBagadiaa deleted the register-batch-features branch December 13, 2023 23:14
github-actions bot pushed a commit that referenced this pull request Dec 13, 2023
@RiddhiBagadiaa
Register batch features (#1195)
26ae58f
RiddhiBagadiaa added a commit that referenced this pull request Dec 14, 2023
@RiddhiBagadiaa
Register batch features (#1195)
ae5470d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aolfat aolfat aolfat left review comments

@sdreyer sdreyer sdreyer left review comments

@ahmadnazeri ahmadnazeri ahmadnazeri left review comments

@anthonylasso anthonylasso anthonylasso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@RiddhiBagadiaa @aolfat @anthonylasso @sdreyer @ahmadnazeri