Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task: Validate existing variant hasn't changed on key fields #1196

Merged
merged 5 commits into from
Dec 6, 2023
Merged

Task: Validate existing variant hasn't changed on key fields #1196

merged 5 commits into from
Dec 6, 2023

Conversation

aolfat
Copy link
Contributor

@aolfat aolfat commented Dec 5, 2023

Description

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@aolfat aolfat temporarily deployed to Integration testing December 5, 2023 02:06 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 5, 2023 02:06 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 5, 2023 02:06 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 5, 2023 05:52 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 5, 2023 05:52 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 5, 2023 05:52 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 5, 2023 06:01 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 5, 2023 06:01 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 5, 2023 06:01 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 5, 2023 17:26 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 5, 2023 22:44 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 5, 2023 22:44 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 5, 2023 22:44 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 5, 2023 22:44 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 5, 2023 22:44 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 5, 2023 22:44 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 5, 2023 22:44 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 5, 2023 23:23 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 5, 2023 23:23 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 5, 2023 23:23 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 5, 2023 23:23 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 5, 2023 23:23 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 5, 2023 23:23 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 5, 2023 23:23 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 5, 2023 23:23 — with GitHub Actions Inactive
epps
epps reviewed Dec 6, 2023
View reviewed changes
metadata/metadata.go Outdated Show resolved Hide resolved
epps
epps approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@epps epps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@aolfat aolfat temporarily deployed to Integration testing December 6, 2023 18:00 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 6, 2023 18:00 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 6, 2023 18:00 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 6, 2023 18:00 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 6, 2023 18:00 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 6, 2023 18:00 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 6, 2023 18:00 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing December 6, 2023 18:00 — with GitHub Actions Inactive
@aolfat aolfat merged commit 26114f8 into main Dec 6, 2023
41 checks passed
@aolfat aolfat deleted the task/check_equivalent_on_variant branch December 6, 2023 18:38
sdreyer pushed a commit that referenced this pull request Dec 6, 2023
@aolfat @sdreyer
Task: Validate existing variant hasn't changed on key fields (#1196)
8412774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epps epps epps approved these changes

@ahmadnazeri ahmadnazeri ahmadnazeri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aolfat @epps @ahmadnazeri