-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MD5 Hash of offline_store_spark_runner.py
#1213
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s are uploaded to cloud object storage
epps
temporarily deployed
to
Integration testing
December 13, 2023 05:02
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
December 13, 2023 05:02
— with
GitHub Actions
Inactive
epps
had a problem deploying
to
Integration testing
December 13, 2023 05:03
— with
GitHub Actions
Failure
epps
temporarily deployed
to
Integration testing
December 13, 2023 05:03
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
December 13, 2023 05:03
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
December 13, 2023 05:03
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
December 13, 2023 05:03
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
December 13, 2023 05:03
— with
GitHub Actions
Inactive
ahmadnazeri
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; only thing is if we want to have the ability to overriding it to previous versions.
sdreyer
approved these changes
Dec 14, 2023
sdreyer
temporarily deployed
to
Integration testing
December 14, 2023 21:02
— with
GitHub Actions
Inactive
sdreyer
temporarily deployed
to
Integration testing
December 14, 2023 21:02
— with
GitHub Actions
Inactive
sdreyer
temporarily deployed
to
Integration testing
December 14, 2023 21:02
— with
GitHub Actions
Inactive
sdreyer
temporarily deployed
to
Integration testing
December 14, 2023 21:02
— with
GitHub Actions
Inactive
sdreyer
temporarily deployed
to
Integration testing
December 14, 2023 21:02
— with
GitHub Actions
Inactive
sdreyer
temporarily deployed
to
Integration testing
December 14, 2023 21:02
— with
GitHub Actions
Inactive
sdreyer
temporarily deployed
to
Integration testing
December 14, 2023 21:02
— with
GitHub Actions
Inactive
sdreyer
temporarily deployed
to
Integration testing
December 14, 2023 21:02
— with
GitHub Actions
Inactive
sdreyer
temporarily deployed
to
Integration testing
December 15, 2023 17:52
— with
GitHub Actions
Inactive
sdreyer
temporarily deployed
to
Integration testing
December 15, 2023 17:52
— with
GitHub Actions
Inactive
sdreyer
temporarily deployed
to
Integration testing
December 15, 2023 17:52
— with
GitHub Actions
Inactive
sdreyer
temporarily deployed
to
Integration testing
December 15, 2023 17:52
— with
GitHub Actions
Inactive
sdreyer
temporarily deployed
to
Integration testing
December 15, 2023 17:52
— with
GitHub Actions
Inactive
sdreyer
temporarily deployed
to
Integration testing
December 15, 2023 17:52
— with
GitHub Actions
Inactive
sdreyer
had a problem deploying
to
Integration testing
December 15, 2023 17:52
— with
GitHub Actions
Failure
sdreyer
temporarily deployed
to
Integration testing
December 15, 2023 17:52
— with
GitHub Actions
Inactive
sdreyer
temporarily deployed
to
Integration testing
December 15, 2023 20:57
— with
GitHub Actions
Inactive
sdreyer
temporarily deployed
to
Integration testing
December 15, 2023 20:57
— with
GitHub Actions
Inactive
sdreyer
temporarily deployed
to
Integration testing
December 15, 2023 20:57
— with
GitHub Actions
Inactive
sdreyer
temporarily deployed
to
Integration testing
December 15, 2023 20:57
— with
GitHub Actions
Inactive
sdreyer
temporarily deployed
to
Integration testing
December 15, 2023 20:57
— with
GitHub Actions
Inactive
sdreyer
temporarily deployed
to
Integration testing
December 15, 2023 20:58
— with
GitHub Actions
Inactive
sdreyer
temporarily deployed
to
Integration testing
December 15, 2023 20:58
— with
GitHub Actions
Inactive
sdreyer
temporarily deployed
to
Integration testing
December 15, 2023 20:58
— with
GitHub Actions
Inactive
github-actions bot
pushed a commit
that referenced
this pull request
Dec 15, 2023
Co-authored-by: sdreyer <sterling@featureform.com>
aolfat
pushed a commit
that referenced
this pull request
Jan 3, 2024
Co-authored-by: sdreyer <sterling@featureform.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that newer/different versions of
offline_store_spark_runner.py
are uploaded to cloud object storage by writing the MD5 hash of the file in the container and adding this as a suffix to the filename that's uploaded.Type of change
Select type(s) of change
Checklist: