Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MD5 Hash of offline_store_spark_runner.py #1213

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

epps
Copy link
Contributor

@epps epps commented Dec 13, 2023

Description

This PR ensures that newer/different versions of offline_store_spark_runner.py are uploaded to cloud object storage by writing the MD5 hash of the file in the container and adding this as a suffix to the filename that's uploaded.

Type of change

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@epps epps temporarily deployed to Integration testing December 13, 2023 05:02 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing December 13, 2023 05:02 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing December 13, 2023 05:03 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing December 13, 2023 05:03 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing December 13, 2023 05:03 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing December 13, 2023 05:03 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing December 13, 2023 05:03 — with GitHub Actions Inactive
Copy link
Contributor

@ahmadnazeri ahmadnazeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; only thing is if we want to have the ability to overriding it to previous versions.

@sdreyer sdreyer temporarily deployed to Integration testing December 15, 2023 17:52 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing December 15, 2023 20:57 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing December 15, 2023 20:57 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing December 15, 2023 20:57 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing December 15, 2023 20:57 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing December 15, 2023 20:57 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing December 15, 2023 20:58 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing December 15, 2023 20:58 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing December 15, 2023 20:58 — with GitHub Actions Inactive
@epps epps merged commit 6019266 into main Dec 15, 2023
41 checks passed
@epps epps deleted the task/md5-hash-offline-store-runner-file branch December 15, 2023 21:12
github-actions bot pushed a commit that referenced this pull request Dec 15, 2023
Co-authored-by: sdreyer <sterling@featureform.com>
aolfat pushed a commit that referenced this pull request Jan 3, 2024
Co-authored-by: sdreyer <sterling@featureform.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants