Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Install-Upgrade ETCD fix. #1220

Merged
merged 7 commits into from
Dec 15, 2023
Merged

Conversation

anthonylasso
Copy link
Contributor

@anthonylasso anthonylasso commented Dec 14, 2023

Description

This PR creates a configmap that dynamically sets the ETCD_INITIAL_CLUSTER_STATE env variable that is read by the ETCD statefulset This means we can skip needing to pass the value during helm upgrades.

⚠️ Important Note ⚠️

When upgrading a cluster, we may want to keep the currently installed release values, while also including any new chart values/props that may have changed.

First save the existing release values to a .yaml file. Then use the -f flag with the filename in the upgrade command to port them to the new release.

  • helm get values featureform -o yaml > ff.yaml
  • helm upgrade -f ff.yaml featureform ./charts/featureform --version x.y.z

closes #526-ent

install / upgrade
Screenshot 2023-12-14 at 4 19 44 PM

env check
Screenshot 2023-12-13 at 8 56 58 PM

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@anthonylasso anthonylasso merged commit 2242007 into main Dec 15, 2023
41 checks passed
@anthonylasso anthonylasso deleted the feature/526/etcd-install-upgrade-fix branch December 15, 2023 16:19
github-actions bot pushed a commit that referenced this pull request Dec 15, 2023
Co-authored-by: sdreyer <sterling@featureform.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants