-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm Install-Upgrade ETCD fix. #1220
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonylasso
temporarily deployed
to
Integration testing
December 14, 2023 03:18
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
December 14, 2023 03:18
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
December 14, 2023 03:18
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
December 14, 2023 03:18
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
December 14, 2023 03:18
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
December 14, 2023 03:18
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
December 14, 2023 03:19
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
December 14, 2023 03:19
— with
GitHub Actions
Inactive
sdreyer
approved these changes
Dec 14, 2023
anthonylasso
temporarily deployed
to
Integration testing
December 14, 2023 21:26
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
December 14, 2023 21:26
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
December 14, 2023 21:26
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
December 14, 2023 21:26
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
December 14, 2023 21:26
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
December 14, 2023 21:26
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
December 14, 2023 21:26
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
December 14, 2023 21:26
— with
GitHub Actions
Inactive
sdreyer
had a problem deploying
to
Integration testing
December 14, 2023 22:57
— with
GitHub Actions
Error
sdreyer
had a problem deploying
to
Integration testing
December 14, 2023 22:57
— with
GitHub Actions
Error
sdreyer
had a problem deploying
to
Integration testing
December 14, 2023 22:57
— with
GitHub Actions
Error
sdreyer
had a problem deploying
to
Integration testing
December 14, 2023 22:57
— with
GitHub Actions
Error
sdreyer
had a problem deploying
to
Integration testing
December 14, 2023 22:57
— with
GitHub Actions
Error
sdreyer
temporarily deployed
to
Integration testing
December 14, 2023 22:57
— with
GitHub Actions
Inactive
sdreyer
had a problem deploying
to
Integration testing
December 14, 2023 22:57
— with
GitHub Actions
Error
sdreyer
had a problem deploying
to
Integration testing
December 14, 2023 22:57
— with
GitHub Actions
Error
….com/featureform/featureform into feature/526/etcd-install-upgrade-fix
anthonylasso
temporarily deployed
to
Integration testing
December 14, 2023 23:01
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
December 14, 2023 23:01
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
December 14, 2023 23:01
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
December 14, 2023 23:01
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
December 14, 2023 23:01
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
December 14, 2023 23:01
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
December 14, 2023 23:01
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
December 14, 2023 23:01
— with
GitHub Actions
Inactive
github-actions bot
pushed a commit
that referenced
this pull request
Dec 15, 2023
Co-authored-by: sdreyer <sterling@featureform.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates a configmap that dynamically sets the
ETCD_INITIAL_CLUSTER_STATE
env variable that is read by the ETCD statefulset This means we can skip needing to pass the value during helm upgrades.When upgrading a cluster, we may want to keep the currently installed release values, while also including any new chart values/props that may have changed.
First save the existing release values to a
.yaml
file. Then use the -f flag with the filename in the upgrade command to port them to the new release.closes #526-ent
install / upgrade
env check
Type of change
Does this correspond to an open issue?
Select type(s) of change
Checklist: