-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Healthy Providers Aren't Rechecked When Reapplied #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epps
temporarily deployed
to
Integration testing
January 5, 2024 23:02
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
January 5, 2024 23:02
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
January 5, 2024 23:02
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
January 5, 2024 23:02
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
January 5, 2024 23:02
— with
GitHub Actions
Inactive
epps
had a problem deploying
to
Integration testing
January 5, 2024 23:02
— with
GitHub Actions
Failure
epps
had a problem deploying
to
Integration testing
January 5, 2024 23:02
— with
GitHub Actions
Failure
epps
temporarily deployed
to
Integration testing
January 5, 2024 23:02
— with
GitHub Actions
Inactive
…ed or previously failed
epps
force-pushed
the
bugfix/reapplying-provider-healthcheck
branch
from
January 8, 2024 18:37
50b83ef
to
6ea369c
Compare
epps
temporarily deployed
to
Integration testing
January 8, 2024 18:39
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
January 8, 2024 18:39
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
January 8, 2024 18:39
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
January 8, 2024 18:39
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
January 8, 2024 18:39
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
January 8, 2024 18:39
— with
GitHub Actions
Inactive
epps
had a problem deploying
to
Integration testing
January 8, 2024 18:39
— with
GitHub Actions
Failure
epps
had a problem deploying
to
Integration testing
January 8, 2024 18:39
— with
GitHub Actions
Failure
epps
temporarily deployed
to
Integration testing
January 8, 2024 21:50
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
January 8, 2024 21:50
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
January 8, 2024 21:50
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
January 8, 2024 21:50
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
January 8, 2024 21:50
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
January 8, 2024 21:50
— with
GitHub Actions
Inactive
epps
had a problem deploying
to
Integration testing
January 8, 2024 21:50
— with
GitHub Actions
Failure
epps
had a problem deploying
to
Integration testing
January 8, 2024 21:50
— with
GitHub Actions
Failure
epps
temporarily deployed
to
Integration testing
January 11, 2024 18:55
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
January 11, 2024 18:55
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
January 11, 2024 19:03
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
January 11, 2024 19:03
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
January 11, 2024 19:03
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
January 11, 2024 19:03
— with
GitHub Actions
Inactive
epps
had a problem deploying
to
Integration testing
January 11, 2024 19:03
— with
GitHub Actions
Failure
epps
had a problem deploying
to
Integration testing
January 11, 2024 19:03
— with
GitHub Actions
Failure
epps
temporarily deployed
to
Integration testing
January 11, 2024 19:32
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
January 11, 2024 19:32
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
January 11, 2024 19:32
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
January 11, 2024 19:32
— with
GitHub Actions
Inactive
epps
had a problem deploying
to
Integration testing
January 11, 2024 19:32
— with
GitHub Actions
Failure
epps
temporarily deployed
to
Integration testing
January 11, 2024 19:32
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
January 11, 2024 19:33
— with
GitHub Actions
Inactive
epps
had a problem deploying
to
Integration testing
January 11, 2024 19:33
— with
GitHub Actions
Failure
sdreyer
temporarily deployed
to
Integration testing
January 18, 2024 00:12
— with
GitHub Actions
Inactive
sdreyer
temporarily deployed
to
Integration testing
January 18, 2024 00:12
— with
GitHub Actions
Inactive
sdreyer
temporarily deployed
to
Integration testing
January 18, 2024 00:12
— with
GitHub Actions
Inactive
sdreyer
temporarily deployed
to
Integration testing
January 18, 2024 00:12
— with
GitHub Actions
Inactive
sdreyer
temporarily deployed
to
Integration testing
January 18, 2024 00:13
— with
GitHub Actions
Inactive
sdreyer
temporarily deployed
to
Integration testing
January 18, 2024 00:13
— with
GitHub Actions
Inactive
sdreyer
temporarily deployed
to
Integration testing
January 18, 2024 00:13
— with
GitHub Actions
Inactive
sdreyer
temporarily deployed
to
Integration testing
January 18, 2024 00:13
— with
GitHub Actions
Inactive
sdreyer
approved these changes
Jan 19, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jan 19, 2024
Co-authored-by: sdreyer <sterling@featureform.com>
epps
added a commit
that referenced
this pull request
Jan 23, 2024
Co-authored-by: sdreyer <sterling@featureform.com>
sdreyer
added a commit
that referenced
this pull request
Jan 24, 2024
Co-authored-by: sdreyer <sterling@featureform.com>
ahmadnazeri
pushed a commit
that referenced
this pull request
Jan 25, 2024
Co-authored-by: sdreyer <sterling@featureform.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, if healthy providers are re-applied, their health checks are run again; however, this is undesirable behavior. This PR introduces changes that ensure that applied providers have health checks only if:
Type of change
Select type(s) of change
Checklist: