Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Healthy Providers Aren't Rechecked When Reapplied #1231

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

epps
Copy link
Contributor

@epps epps commented Jan 5, 2024

Description

Currently, if healthy providers are re-applied, their health checks are run again; however, this is undesirable behavior. This PR introduces changes that ensure that applied providers have health checks only if:

  • they are being created for the first time
  • they already existed but have different configs
  • they already existed but previously failed their health checks

Type of change

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@epps epps requested review from aolfat and sdreyer January 5, 2024 22:59
@epps epps temporarily deployed to Integration testing January 5, 2024 23:02 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing January 5, 2024 23:02 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing January 5, 2024 23:02 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing January 5, 2024 23:02 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing January 5, 2024 23:02 — with GitHub Actions Inactive
@epps epps had a problem deploying to Integration testing January 5, 2024 23:02 — with GitHub Actions Failure
@epps epps had a problem deploying to Integration testing January 5, 2024 23:02 — with GitHub Actions Failure
@epps epps temporarily deployed to Integration testing January 5, 2024 23:02 — with GitHub Actions Inactive
@epps epps force-pushed the bugfix/reapplying-provider-healthcheck branch from 50b83ef to 6ea369c Compare January 8, 2024 18:37
@epps epps temporarily deployed to Integration testing January 8, 2024 18:39 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing January 8, 2024 18:39 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing January 8, 2024 18:39 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing January 8, 2024 18:39 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing January 8, 2024 18:39 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing January 8, 2024 18:39 — with GitHub Actions Inactive
@epps epps had a problem deploying to Integration testing January 8, 2024 18:39 — with GitHub Actions Failure
@epps epps had a problem deploying to Integration testing January 8, 2024 18:39 — with GitHub Actions Failure
@epps epps temporarily deployed to Integration testing January 8, 2024 21:50 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing January 8, 2024 21:50 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing January 8, 2024 21:50 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing January 8, 2024 21:50 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing January 8, 2024 21:50 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing January 8, 2024 21:50 — with GitHub Actions Inactive
@epps epps had a problem deploying to Integration testing January 8, 2024 21:50 — with GitHub Actions Failure
@epps epps had a problem deploying to Integration testing January 8, 2024 21:50 — with GitHub Actions Failure
@epps epps temporarily deployed to Integration testing January 11, 2024 18:55 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing January 11, 2024 18:55 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing January 11, 2024 19:03 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing January 11, 2024 19:03 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing January 11, 2024 19:03 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing January 11, 2024 19:03 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing January 11, 2024 19:32 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing January 11, 2024 19:32 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing January 11, 2024 19:32 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing January 11, 2024 19:32 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing January 11, 2024 19:32 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing January 11, 2024 19:33 — with GitHub Actions Inactive
@epps epps merged commit 8dcb114 into main Jan 19, 2024
41 checks passed
@epps epps deleted the bugfix/reapplying-provider-healthcheck branch January 19, 2024 20:41
github-actions bot pushed a commit that referenced this pull request Jan 19, 2024
Co-authored-by: sdreyer <sterling@featureform.com>
epps added a commit that referenced this pull request Jan 23, 2024
Co-authored-by: sdreyer <sterling@featureform.com>
sdreyer added a commit that referenced this pull request Jan 24, 2024
Co-authored-by: sdreyer <sterling@featureform.com>
ahmadnazeri pushed a commit that referenced this pull request Jan 25, 2024
Co-authored-by: sdreyer <sterling@featureform.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants