Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task: Add inputs to sql transformations #1233

Merged
merged 15 commits into from
Jan 19, 2024
Merged

Task: Add inputs to sql transformations #1233

merged 15 commits into from
Jan 19, 2024

Conversation

aolfat
Copy link
Contributor

@aolfat aolfat commented Jan 10, 2024

Description

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@aolfat aolfat temporarily deployed to Integration testing January 10, 2024 17:25 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 10, 2024 17:25 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 10, 2024 17:25 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 10, 2024 17:25 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 10, 2024 17:25 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 10, 2024 17:25 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 11, 2024 16:43 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 11, 2024 16:43 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 11, 2024 16:43 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 11, 2024 16:43 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 11, 2024 16:43 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 11, 2024 16:43 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 11, 2024 17:12 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 11, 2024 17:12 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 11, 2024 17:12 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 11, 2024 17:12 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 11, 2024 17:12 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 11, 2024 17:12 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 11, 2024 17:28 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 11, 2024 17:28 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 11, 2024 17:28 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 11, 2024 17:28 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 11, 2024 17:28 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 11, 2024 17:28 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 18, 2024 21:46 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 18, 2024 21:46 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 18, 2024 21:46 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 18, 2024 21:46 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 18, 2024 21:46 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 18, 2024 21:46 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 19, 2024 14:49 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 19, 2024 14:49 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 19, 2024 14:49 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 19, 2024 14:49 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 19, 2024 14:49 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 19, 2024 14:49 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 19, 2024 14:49 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing January 19, 2024 14:49 — with GitHub Actions Inactive
@sdreyer sdreyer merged commit 5b82655 into main Jan 19, 2024
8 of 9 checks passed
@sdreyer sdreyer deleted the task/make_inputs_parameter_to_sql branch January 19, 2024 18:34
github-actions bot pushed a commit that referenced this pull request Jan 19, 2024
@aolfat @sdreyer
Task: Add inputs to sql transformations (#1233)
74e08c4 
Co-authored-by: sdreyer <sterling@featureform.com>
@sdreyer sdreyer temporarily deployed to Integration testing January 19, 2024 18:36 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing January 19, 2024 18:36 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing January 19, 2024 18:36 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing January 19, 2024 18:36 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing January 19, 2024 18:36 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing January 19, 2024 18:36 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing January 19, 2024 18:36 — with GitHub Actions Inactive
epps
epps reviewed Jan 19, 2024
View reviewed changes
client/src/featureform/register.py
)

if not isinstance(self.inputs, list):
raise ValueError("Dataframe transformation inputs must be a list")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be SQL, right? @sdreyer

epps pushed a commit that referenced this pull request Jan 23, 2024
@aolfat @sdreyer @epps
Task: Add inputs to sql transformations (#1233)
e8193ab 
Co-authored-by: sdreyer <sterling@featureform.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epps epps epps left review comments

@sdreyer sdreyer sdreyer approved these changes

@ahmadnazeri ahmadnazeri ahmadnazeri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aolfat @epps @sdreyer @ahmadnazeri