Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing local mode #1294

Merged
merged 15 commits into from
Jan 31, 2024
Merged

Removing local mode #1294

merged 15 commits into from
Jan 31, 2024

Conversation

ahmadnazeri
Copy link
Contributor

Description

Removing local mode from the client and cli so users cannot utilize local mode anymore. This does not remove all the code related to local mode but rather just access to it.

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@ahmadnazeri ahmadnazeri marked this pull request as ready for review January 31, 2024 22:54
@ahmadnazeri ahmadnazeri merged commit 5b131a1 into main Jan 31, 2024
41 checks passed
@ahmadnazeri ahmadnazeri deleted the feature/remove_localmode branch January 31, 2024 23:07
github-actions bot pushed a commit that referenced this pull request Jan 31, 2024
sdreyer pushed a commit that referenced this pull request Feb 12, 2024
@dvdr00t
Copy link

dvdr00t commented Mar 4, 2024

Hello everyone,
I was wondering why the local mode has been "removed" from the main package and if there is a valuable alternative to that. I have been using the PyPI package of Featureform version 1.11.2 and I need the provider to be a local provider as I have multiple .csv files from which I need to infere features. How does that work now?

Thanks!

@sdreyer
Copy link
Collaborator

sdreyer commented Mar 13, 2024

Hey @dvdr00t this slipped past. For now localmode is effectively deprecated but can still be used in the older package versions. We're working on making it simpler to run the core codebase as a single executable locally, which will have access to local files and can act as a replacement to localmode for now. This is mainly due to the overhead of managing two separate code bases for the same functionality. The changes to the core backend should be complete in a couple weeks.

@dvdr00t
Copy link

dvdr00t commented Mar 14, 2024

Cool, many thanks for your reply, @sdreyer! Looking forward to the new version! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants