Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix banner reload issue #1300

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Fix banner reload issue #1300

merged 1 commit into from
Jan 31, 2024

Conversation

anthonylasso
Copy link
Contributor

Description

Directly sets the styling on the top bar banner. makeStyles seems to load slower than the component's original styling, so setting directly to fix for now.

closes #1299

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@anthonylasso anthonylasso merged commit 44ec659 into main Jan 31, 2024
40 of 44 checks passed
@anthonylasso anthonylasso deleted the bugfix/1299/blue-banner branch January 31, 2024 18:04
github-actions bot pushed a commit that referenced this pull request Jan 31, 2024
sdreyer pushed a commit that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Banner color changes on slow refresh
2 participants