-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Modal Null Rows Fix #1306
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonylasso
temporarily deployed
to
Integration testing
February 2, 2024 20:16
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
February 2, 2024 20:16
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
February 2, 2024 20:16
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
February 2, 2024 20:16
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
February 2, 2024 20:16
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
February 2, 2024 20:16
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
February 2, 2024 20:17
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
February 2, 2024 20:17
— with
GitHub Actions
Inactive
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1306 +/- ##
===========================================
+ Coverage 49.27% 61.05% +11.78%
===========================================
Files 117 26 -91
Lines 21903 4373 -17530
Branches 0 647 +647
===========================================
- Hits 10793 2670 -8123
+ Misses 10383 1581 -8802
+ Partials 727 122 -605 ☔ View full report in Codecov by Sentry. |
anthonylasso
temporarily deployed
to
Integration testing
February 5, 2024 15:40
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
February 5, 2024 15:40
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
February 5, 2024 15:40
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
February 5, 2024 15:40
— with
GitHub Actions
Inactive
anthonylasso
had a problem deploying
to
Integration testing
February 5, 2024 15:40
— with
GitHub Actions
Failure
anthonylasso
temporarily deployed
to
Integration testing
February 5, 2024 15:40
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
February 5, 2024 15:40
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
February 5, 2024 15:40
— with
GitHub Actions
Inactive
sdreyer
approved these changes
Feb 6, 2024
sdreyer
pushed a commit
that referenced
this pull request
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the dashboard crashes if the source modal response
rows
property isnull
Source Dialog Tests
Type of change
Does this correspond to an open issue?
Select type(s) of change
Checklist: