Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redshift Configuration Correction #1307

Merged
merged 8 commits into from
Feb 3, 2024
Merged

Conversation

epps
Copy link
Contributor

@epps epps commented Feb 3, 2024

Description

This PR corrects a mismatch the client-side's configuration object for Redshift, adds a value for SSL mode, and adds a health check for the provider.

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@epps epps requested a review from sdreyer February 3, 2024 00:40
@epps epps temporarily deployed to Integration testing February 3, 2024 00:45 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing February 3, 2024 00:45 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing February 3, 2024 00:45 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing February 3, 2024 00:45 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing February 3, 2024 00:45 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing February 3, 2024 00:45 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing February 3, 2024 01:56 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing February 3, 2024 01:56 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing February 3, 2024 01:56 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing February 3, 2024 01:56 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing February 3, 2024 02:06 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing February 3, 2024 02:06 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing February 3, 2024 02:07 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing February 3, 2024 02:07 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing February 3, 2024 02:07 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing February 3, 2024 02:07 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing February 3, 2024 02:22 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing February 3, 2024 02:22 — with GitHub Actions Inactive
Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: 270 lines in your changes are missing coverage. Please review.

Comparison is base (7fdb3ec) 49.27% compared to head (b5dc00e) 61.06%.
Report is 243 commits behind head on main.

Files Patch % Lines
client/src/featureform/serving.py 26.31% 81 Missing and 3 partials ⚠️
client/src/featureform/register.py 77.94% 32 Missing and 13 partials ⚠️
client/src/featureform/resources.py 73.21% 45 Missing ⚠️
client/src/featureform/deploy.py 62.39% 34 Missing and 10 partials ⚠️
client/src/featureform/cli.py 49.01% 26 Missing ⚠️
client/src/featureform/client.py 10.00% 17 Missing and 1 partial ⚠️
client/src/featureform/status_display.py 40.00% 3 Missing ⚠️
client/src/featureform/feature_flag.py 66.66% 1 Missing and 1 partial ⚠️
client/src/featureform/tls.py 50.00% 2 Missing ⚠️
client/src/featureform/enums.py 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1307       +/-   ##
===========================================
+ Coverage   49.27%   61.06%   +11.78%     
===========================================
  Files         117       26       -91     
  Lines       21903     4374    -17529     
  Branches        0      647      +647     
===========================================
- Hits        10793     2671     -8122     
+ Misses      10383     1581     -8802     
+ Partials      727      122      -605     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdreyer sdreyer temporarily deployed to Integration testing February 3, 2024 05:03 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing February 3, 2024 05:03 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing February 3, 2024 05:03 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing February 3, 2024 05:03 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing February 3, 2024 05:03 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing February 3, 2024 05:03 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing February 3, 2024 05:03 — with GitHub Actions Inactive
@sdreyer sdreyer merged commit 0861bf3 into main Feb 3, 2024
42 of 44 checks passed
@sdreyer sdreyer deleted the hotfix/redshift-configuration branch February 3, 2024 05:13
github-actions bot pushed a commit that referenced this pull request Feb 3, 2024
Co-authored-by: sdreyer <sterling@featureform.com>
sdreyer added a commit that referenced this pull request Feb 12, 2024
Co-authored-by: sdreyer <sterling@featureform.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants