Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: make ondemand feature be allowed to passed into as an object #1312

Merged
merged 7 commits into from
Feb 9, 2024

Conversation

aolfat
Copy link
Contributor

@aolfat aolfat commented Feb 6, 2024

Description

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@aolfat aolfat marked this pull request as ready for review February 6, 2024 19:00
@aolfat aolfat temporarily deployed to Integration testing February 6, 2024 19:03 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing February 6, 2024 19:03 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing February 6, 2024 19:03 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing February 6, 2024 19:03 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing February 6, 2024 19:03 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing February 6, 2024 19:03 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing February 6, 2024 19:03 — with GitHub Actions Inactive
metadata/metadata.go Outdated Show resolved Hide resolved
metadata/metadata.go Outdated Show resolved Hide resolved
metadata/metadata.go Outdated Show resolved Hide resolved
@aolfat aolfat temporarily deployed to Integration testing February 9, 2024 19:31 — with GitHub Actions Inactive
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (a014b90) 30.03% compared to head (8a39a99) 53.27%.

Files Patch % Lines
client/src/featureform/serving.py 0.00% 2 Missing ⚠️
client/src/featureform/resources.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1312       +/-   ##
===========================================
+ Coverage   30.03%   53.27%   +23.24%     
===========================================
  Files          87      113       +26     
  Lines       20105    24488     +4383     
  Branches        0      648      +648     
===========================================
+ Hits         6038    13046     +7008     
+ Misses      13470    10170     -3300     
- Partials      597     1272      +675     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aolfat aolfat merged commit 938b812 into main Feb 9, 2024
30 checks passed
@aolfat aolfat deleted the bugfix/ondemand-feature-variant-obj branch February 9, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants