Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Check other definition for cast before calling .Query on it #1321

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

aolfat
Copy link
Contributor

@aolfat aolfat commented Feb 9, 2024

Description

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

Copy link
Contributor

@epps epps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥾 🐛

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (17f4117) 0.00% compared to head (1e69d8d) 53.29%.

Files Patch % Lines
metadata/metadata.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main    #1321       +/-   ##
=========================================
+ Coverage      0   53.29%   +53.29%     
=========================================
  Files         0      113      +113     
  Lines         0    24484    +24484     
  Branches      0      647      +647     
=========================================
+ Hits          0    13048    +13048     
- Misses        0    10166    +10166     
- Partials      0     1270     +1270     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants