Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for bad pathing exception #769 #773

Merged
merged 5 commits into from
May 2, 2023
Merged

Conversation

anthonylasso
Copy link
Contributor

@anthonylasso anthonylasso commented Apr 26, 2023

Description

This PR fixes the bug where setting a bad "type" in the URL leads to a 500 error.
In node, it will route the user to the 404 page.
With nginx the route will send the user back to the homepage.

In the near future I'll create a story to explore using node/next.js server instead of nginx.

Ex.

notFoundPath.mov

Type of change

Does this correspond to an open issue?

#769

Unit Test:

Screenshot 2023-04-26 at 4 44 23 PM

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

-handle nginx's routing. will investigate switching to a node server
-breaks data fetch. will really consider swapping to node for the dashboard. too much fuss with nginx and dynamic routes.
@anthonylasso anthonylasso changed the title Bugfix/769/anthony Bug fix for bad pathing issue #769 Apr 26, 2023
@anthonylasso anthonylasso temporarily deployed to Integration testing April 26, 2023 23:00 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing April 26, 2023 23:00 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing April 26, 2023 23:00 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing April 26, 2023 23:00 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing April 26, 2023 23:00 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #773 (a1740d6) into main (6f7b498) will decrease coverage by 2.93%.
The diff coverage is 54.87%.

@@            Coverage Diff             @@
##             main     #773      +/-   ##
==========================================
- Coverage   59.71%   56.78%   -2.93%     
==========================================
  Files          63       66       +3     
  Lines       12408    12972     +564     
==========================================
- Hits         7409     7366      -43     
- Misses       4232     4889     +657     
+ Partials      767      717      -50     
Impacted Files Coverage Δ
coordinator/coordinator.go 42.67% <0.00%> (-0.13%) ⬇️
helpers/compression/compression.go 0.00% <0.00%> (ø)
provider/k8s.go 9.30% <ø> (-20.90%) ⬇️
provider/provider_config/spark_config.go 58.89% <ø> (+1.84%) ⬆️
provider/provider_type/provider_type.go 100.00% <ø> (ø)
provider/redshift.go 85.24% <ø> (ø)
provider/spark.go 23.25% <ø> (+4.67%) ⬆️
provider/sql.go 65.47% <ø> (-0.31%) ⬇️
runner/worker/worker.go 78.57% <ø> (ø)
serving/serialize.go 74.81% <ø> (-19.58%) ⬇️
... and 7 more

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anthonylasso anthonylasso marked this pull request as draft April 27, 2023 14:02
@anthonylasso anthonylasso changed the title Bug fix for bad pathing issue #769 Draft: Bug fix for bad pathing issue #769 Apr 27, 2023
@anthonylasso anthonylasso temporarily deployed to Integration testing April 27, 2023 21:10 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing April 27, 2023 21:10 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing April 27, 2023 21:10 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing April 27, 2023 21:10 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing April 27, 2023 21:10 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing April 27, 2023 21:10 — with GitHub Actions Inactive
@anthonylasso anthonylasso marked this pull request as ready for review April 27, 2023 21:12
@anthonylasso anthonylasso temporarily deployed to Integration testing April 27, 2023 21:12 — with GitHub Actions Inactive
@anthonylasso anthonylasso changed the title Draft: Bug fix for bad pathing issue #769 Bug fix for bad pathing issue #769 Apr 27, 2023
@anthonylasso anthonylasso changed the title Bug fix for bad pathing issue #769 Bug fix for bad pathing exception #769 Apr 27, 2023
@anthonylasso anthonylasso temporarily deployed to Integration testing April 28, 2023 03:27 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing April 28, 2023 03:27 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing April 28, 2023 03:27 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing April 28, 2023 03:27 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing April 28, 2023 03:27 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing April 28, 2023 03:27 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing April 28, 2023 03:31 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing April 28, 2023 15:06 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing April 28, 2023 15:06 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing April 28, 2023 15:06 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing April 28, 2023 15:06 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing April 28, 2023 15:06 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing April 28, 2023 15:06 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing May 1, 2023 22:04 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing May 1, 2023 22:04 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing May 1, 2023 22:04 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing May 1, 2023 22:04 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing May 1, 2023 22:04 — with GitHub Actions Inactive
@anthonylasso anthonylasso merged commit af6e655 into main May 2, 2023
43 of 46 checks passed
@anthonylasso anthonylasso deleted the bugfix/769/anthony branch May 2, 2023 22:20
sdreyer pushed a commit that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants