-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix for bad pathing exception #769 #773
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-handle nginx's routing. will investigate switching to a node server
-breaks data fetch. will really consider swapping to node for the dashboard. too much fuss with nginx and dynamic routes.
anthonylasso
temporarily deployed
to
Integration testing
April 26, 2023 23:00
— with
GitHub Actions
Inactive
anthonylasso
had a problem deploying
to
Integration testing
April 26, 2023 23:00
— with
GitHub Actions
Failure
anthonylasso
temporarily deployed
to
Integration testing
April 26, 2023 23:00
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
April 26, 2023 23:00
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
April 26, 2023 23:00
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
April 26, 2023 23:00
— with
GitHub Actions
Inactive
anthonylasso
had a problem deploying
to
Integration testing
April 26, 2023 23:01
— with
GitHub Actions
Failure
Codecov Report
@@ Coverage Diff @@
## main #773 +/- ##
==========================================
- Coverage 59.71% 56.78% -2.93%
==========================================
Files 63 66 +3
Lines 12408 12972 +564
==========================================
- Hits 7409 7366 -43
- Misses 4232 4889 +657
+ Partials 767 717 -50
... and 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
anthonylasso
changed the title
Bug fix for bad pathing issue #769
Draft: Bug fix for bad pathing issue #769
Apr 27, 2023
anthonylasso
temporarily deployed
to
Integration testing
April 27, 2023 21:10
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
April 27, 2023 21:10
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
April 27, 2023 21:10
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
April 27, 2023 21:10
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
April 27, 2023 21:10
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
April 27, 2023 21:10
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
April 27, 2023 21:12
— with
GitHub Actions
Inactive
anthonylasso
changed the title
Draft: Bug fix for bad pathing issue #769
Bug fix for bad pathing issue #769
Apr 27, 2023
anthonylasso
changed the title
Bug fix for bad pathing issue #769
Bug fix for bad pathing exception #769
Apr 27, 2023
anthonylasso
temporarily deployed
to
Integration testing
April 28, 2023 03:27
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
April 28, 2023 03:27
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
April 28, 2023 03:27
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
April 28, 2023 03:27
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
April 28, 2023 03:27
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
April 28, 2023 03:27
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
April 28, 2023 03:31
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
April 28, 2023 15:06
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
April 28, 2023 15:06
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
April 28, 2023 15:06
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
April 28, 2023 15:06
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
April 28, 2023 15:06
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
April 28, 2023 15:06
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 1, 2023 22:04
— with
GitHub Actions
Inactive
anthonylasso
had a problem deploying
to
Integration testing
May 1, 2023 22:04
— with
GitHub Actions
Failure
anthonylasso
temporarily deployed
to
Integration testing
May 1, 2023 22:04
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 1, 2023 22:04
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 1, 2023 22:04
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 1, 2023 22:04
— with
GitHub Actions
Inactive
anthonylasso
had a problem deploying
to
Integration testing
May 1, 2023 22:07
— with
GitHub Actions
Failure
sdreyer
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the bug where setting a bad "type" in the URL leads to a 500 error.
In
node
, it will route the user to the404
page.With
nginx
the route will send the user back to the homepage.In the near future I'll create a story to explore using
node
/next.js server
instead ofnginx
.Ex.
notFoundPath.mov
Type of change
Does this correspond to an open issue?
#769
Unit Test:
Select type(s) of change
Checklist: