Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: fixing issue with paths for the Spark files #776

Merged
merged 1 commit into from
May 3, 2023

Conversation

ahmadnazeri
Copy link
Contributor

@ahmadnazeri ahmadnazeri commented Apr 27, 2023

Description

Spark looks for path /app/provider/... for the files by default. The dockerfile copied the Spark files to /app/scripts/.... Fixed the paths for it.

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@ahmadnazeri ahmadnazeri marked this pull request as ready for review April 27, 2023 20:25
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing April 27, 2023 20:29 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing April 27, 2023 20:29 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing April 27, 2023 20:29 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing April 27, 2023 20:29 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing April 27, 2023 20:29 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing April 27, 2023 20:29 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #776 (ce61031) into main (6f7b498) will decrease coverage by 6.10%.
The diff coverage is 12.68%.

@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
- Coverage   59.71%   53.61%   -6.10%     
==========================================
  Files          63       66       +3     
  Lines       12408    12658     +250     
==========================================
- Hits         7409     6787     -622     
- Misses       4232     5229     +997     
+ Partials      767      642     -125     
Impacted Files Coverage Δ
config/config.go 20.00% <0.00%> (-80.00%) ⬇️
coordinator/coordinator.go 42.67% <0.00%> (-0.13%) ⬇️
helpers/compression/compression.go 0.00% <0.00%> (ø)
provider/filepath.go 0.00% <0.00%> (ø)
provider/filestore.go 4.00% <0.00%> (-38.93%) ⬇️
provider/k8s.go 4.14% <0.00%> (-26.06%) ⬇️
provider/spark.go 0.16% <ø> (-18.41%) ⬇️
runner/worker/worker.go 78.57% <ø> (ø)
metadata/metadata.go 71.02% <100.00%> (+2.05%) ⬆️
provider/provider_type/provider_type.go 100.00% <100.00%> (ø)

... and 18 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing April 27, 2023 21:35 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing April 27, 2023 21:35 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing April 27, 2023 21:35 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing April 27, 2023 21:35 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing April 27, 2023 21:35 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing April 27, 2023 21:36 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri merged commit b1528db into main May 3, 2023
43 of 44 checks passed
@ahmadnazeri ahmadnazeri deleted the bugfix/standalone_docker_copy_spark_files branch May 3, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants