-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
throwing an error if input tuple is not of type (str, str) #780
Conversation
Codecov Report
@@ Coverage Diff @@
## main #780 +/- ##
==========================================
- Coverage 59.71% 56.31% -3.40%
==========================================
Files 63 66 +3
Lines 12408 12972 +564
==========================================
- Hits 7409 7305 -104
- Misses 4232 4962 +730
+ Partials 767 705 -62
... and 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd throw a unit test at _verify_tuple
but otherwise approved.
Description
threw a useless error but now throws an error
Type of change
Does this correspond to an open issue?
Closes #779
Select type(s) of change
Checklist: