Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throwing an error if input tuple is not of type (str, str) #780

Merged
merged 6 commits into from
May 3, 2023

Conversation

ahmadnazeri
Copy link
Contributor

@ahmadnazeri ahmadnazeri commented Apr 28, 2023

Description

@local.df_transformation(
    variant="v1",
    inputs=[(compute_user_age, "v1")]
)

threw a useless error but now throws an error

TypeError: input tuple must be of type (str, str); got (LocalSource, str)

Type of change

Does this correspond to an open issue?

Closes #779

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #780 (7c34d25) into main (6f7b498) will decrease coverage by 3.40%.
The diff coverage is 54.87%.

@@            Coverage Diff             @@
##             main     #780      +/-   ##
==========================================
- Coverage   59.71%   56.31%   -3.40%     
==========================================
  Files          63       66       +3     
  Lines       12408    12972     +564     
==========================================
- Hits         7409     7305     -104     
- Misses       4232     4962     +730     
+ Partials      767      705      -62     
Impacted Files Coverage Δ
coordinator/coordinator.go 42.67% <0.00%> (-0.13%) ⬇️
helpers/compression/compression.go 0.00% <0.00%> (ø)
provider/k8s.go 9.30% <ø> (-20.90%) ⬇️
provider/provider_config/spark_config.go 58.89% <ø> (+1.84%) ⬆️
provider/provider_type/provider_type.go 100.00% <ø> (ø)
provider/redshift.go 85.24% <ø> (ø)
provider/spark.go 23.25% <ø> (+4.67%) ⬆️
provider/sql.go 65.47% <ø> (-0.31%) ⬇️
runner/worker/worker.go 78.57% <ø> (ø)
serving/serialize.go 74.81% <ø> (-19.58%) ⬇️
... and 7 more

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing April 28, 2023 01:56 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing April 28, 2023 01:56 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing April 28, 2023 01:56 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing April 28, 2023 01:56 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing April 28, 2023 01:56 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing April 28, 2023 02:22 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing April 28, 2023 02:22 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing April 28, 2023 02:22 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing April 28, 2023 02:22 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing April 28, 2023 02:22 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing April 28, 2023 02:22 — with GitHub Actions Inactive
anthonylasso
anthonylasso previously approved these changes Apr 28, 2023
Copy link
Contributor

@anthonylasso anthonylasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd throw a unit test at _verify_tuple but otherwise approved.

@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing April 28, 2023 15:41 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing May 2, 2023 21:44 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing May 2, 2023 21:45 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing May 2, 2023 21:45 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing May 2, 2023 21:45 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing May 2, 2023 21:45 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing May 2, 2023 21:45 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing May 2, 2023 22:31 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing May 2, 2023 22:32 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing May 2, 2023 22:32 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing May 2, 2023 22:32 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing May 2, 2023 22:32 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing May 2, 2023 23:00 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing May 2, 2023 23:00 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing May 2, 2023 23:00 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing May 2, 2023 23:00 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing May 2, 2023 23:00 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing May 2, 2023 23:02 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing May 3, 2023 14:20 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing May 3, 2023 14:20 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing May 3, 2023 14:20 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing May 3, 2023 14:20 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing May 3, 2023 14:20 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing May 3, 2023 14:20 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri merged commit 0793281 into main May 3, 2023
48 checks passed
@ahmadnazeri ahmadnazeri deleted the bugfix/df_transformations_inputs branch May 3, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unclear Typing Around Localmode DF Transformation Inputs
3 participants