-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard Routing and Build Optimizations #781
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-handle nginx's routing. will investigate switching to a node server
-breaks data fetch. will really consider swapping to node for the dashboard. too much fuss with nginx and dynamic routes.
-reduces dashboard image size by ~1.6GBs. -main featureform image size reduced to ~1.9GBs from ~4.2GBs. a ~50% improvement. -fixes all previous nginx dashboard routing issues -iterating on testing: local, k8s, pure docker.
anthonylasso
temporarily deployed
to
Integration testing
April 28, 2023 20:58
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
April 28, 2023 20:58
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
April 28, 2023 20:58
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
April 28, 2023 20:58
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
April 28, 2023 20:58
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
April 28, 2023 20:58
— with
GitHub Actions
Inactive
Codecov Report
@@ Coverage Diff @@
## main #781 +/- ##
==========================================
- Coverage 59.71% 56.78% -2.93%
==========================================
Files 63 66 +3
Lines 12408 12974 +566
==========================================
- Hits 7409 7367 -42
- Misses 4232 4889 +657
+ Partials 767 718 -49
... and 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
anthonylasso
temporarily deployed
to
Integration testing
May 1, 2023 22:05
— with
GitHub Actions
Inactive
anthonylasso
had a problem deploying
to
Integration testing
May 1, 2023 22:05
— with
GitHub Actions
Failure
anthonylasso
temporarily deployed
to
Integration testing
May 1, 2023 22:05
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 1, 2023 22:05
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 1, 2023 22:06
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 1, 2023 22:06
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 2, 2023 01:09
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 2, 2023 01:09
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 2, 2023 01:09
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 2, 2023 01:09
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 2, 2023 01:09
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 2, 2023 01:09
— with
GitHub Actions
Inactive
anthonylasso
had a problem deploying
to
Integration testing
May 2, 2023 01:11
— with
GitHub Actions
Error
anthonylasso
temporarily deployed
to
Integration testing
May 9, 2023 21:05
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 9, 2023 21:05
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 9, 2023 21:05
— with
GitHub Actions
Inactive
anthonylasso
had a problem deploying
to
Integration testing
May 9, 2023 21:05
— with
GitHub Actions
Failure
anthonylasso
temporarily deployed
to
Integration testing
May 9, 2023 21:06
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 9, 2023 21:08
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 9, 2023 21:27
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 9, 2023 21:27
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 9, 2023 21:27
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 9, 2023 21:27
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 9, 2023 21:27
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 9, 2023 21:27
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 10, 2023 18:53
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 10, 2023 18:53
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 10, 2023 18:53
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 10, 2023 18:53
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 10, 2023 18:53
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 10, 2023 18:53
— with
GitHub Actions
Inactive
anthonylasso
had a problem deploying
to
Integration testing
May 10, 2023 18:55
— with
GitHub Actions
Failure
anthonylasso
temporarily deployed
to
Integration testing
May 10, 2023 19:14
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 10, 2023 19:14
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 10, 2023 19:14
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 10, 2023 19:16
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 10, 2023 19:16
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
May 10, 2023 19:16
— with
GitHub Actions
Inactive
ahmadnazeri
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
nginx
location routing is not gracefully handlingnext.js
dynamic routing in a graceful and scalable way.By using an internal node server and proxying dashboard requests to it, all
next.js
features are enabled without special configurations.next.js
output file tracing also helps reduce the overall featureform image size (~4.2GBs
vs.~1.9GBs
).More importantly, the production dashboard operates exactly as our local node development environments do. Currently unexpected errors can occur once our code hits production that we might miss in local dev.
Proposal Document
Excalidraw Design
This merge request will remain in draft for the next couple of weeks, to enable thorough testing + evaluation.
Testing Schedule:
Type of change
Routing architecture + docker build change.
Does this correspond to an open issue?
#774
Select type(s) of change
Checklist: