Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Reformat and cleanup status displayer #782

Merged
merged 6 commits into from
May 12, 2023

Conversation

aolfat
Copy link
Contributor

@aolfat aolfat commented Apr 28, 2023

Description

  • Don't make requests for resources that are already completed
  • If resources are empty don't display anything
  • Cleanup code (put it in a class instead of nested functions)

Before:

image

After:

image

before: 664 api calls to fetch resources
after: 114 api calls

~80% less calls

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@aolfat aolfat changed the title Task: Reformat and Cceanup status displayer Task: Reformat and cleanup status displayer Apr 28, 2023
@aolfat aolfat marked this pull request as ready for review April 28, 2023 21:11
@aolfat aolfat temporarily deployed to Integration testing April 28, 2023 21:13 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing April 28, 2023 21:13 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #782 (3fa1a03) into main (6f7b498) will decrease coverage by 2.91%.
The diff coverage is 69.56%.

@@            Coverage Diff             @@
##             main     #782      +/-   ##
==========================================
- Coverage   59.71%   56.80%   -2.91%     
==========================================
  Files          63       66       +3     
  Lines       12408    12974     +566     
==========================================
- Hits         7409     7370      -39     
- Misses       4232     4887     +655     
+ Partials      767      717      -50     
Impacted Files Coverage Δ
helpers/compression/compression.go 0.00% <ø> (ø)
kubernetes/kubernetes.go 21.47% <ø> (+0.79%) ⬆️
metadata/metadata.go 71.02% <ø> (+2.05%) ⬆️
provider/bigquery.go 70.00% <ø> (-0.18%) ⬇️
provider/filepath.go 59.55% <ø> (ø)
provider/filestore.go 25.54% <ø> (-17.39%) ⬇️
provider/k8s.go 9.30% <ø> (-20.90%) ⬇️
provider/provider_config/spark_config.go 60.60% <ø> (+3.55%) ⬆️
provider/provider_type/provider_type.go 100.00% <ø> (ø)
provider/redshift.go 85.24% <ø> (ø)
... and 7 more

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aolfat aolfat temporarily deployed to Integration testing April 28, 2023 21:25 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing April 28, 2023 21:28 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing April 28, 2023 21:28 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing April 28, 2023 21:28 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing April 28, 2023 21:28 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing April 28, 2023 21:28 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing April 28, 2023 21:28 — with GitHub Actions Inactive
sdreyer
sdreyer previously approved these changes May 2, 2023
@aolfat aolfat temporarily deployed to Integration testing May 9, 2023 20:08 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing May 9, 2023 20:08 — with GitHub Actions Inactive
@aolfat aolfat had a problem deploying to Integration testing May 9, 2023 20:08 — with GitHub Actions Failure
@aolfat aolfat temporarily deployed to Integration testing May 9, 2023 20:08 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing May 9, 2023 20:08 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing May 9, 2023 20:08 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing May 10, 2023 23:33 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing May 10, 2023 23:33 — with GitHub Actions Inactive
@aolfat aolfat had a problem deploying to Integration testing May 10, 2023 23:36 — with GitHub Actions Failure
@aolfat aolfat had a problem deploying to Integration testing May 11, 2023 20:08 — with GitHub Actions Failure
@aolfat aolfat temporarily deployed to Integration testing May 11, 2023 23:50 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing May 11, 2023 23:50 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing May 11, 2023 23:50 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing May 11, 2023 23:50 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing May 11, 2023 23:50 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing May 11, 2023 23:50 — with GitHub Actions Inactive
@aolfat aolfat had a problem deploying to Integration testing May 11, 2023 23:52 — with GitHub Actions Failure
@aolfat aolfat temporarily deployed to Integration testing May 12, 2023 16:33 — with GitHub Actions Inactive
@aolfat aolfat force-pushed the task/cleanup_display_statuses branch from 3fa1a03 to cfa3f81 Compare May 12, 2023 17:55
@aolfat aolfat merged commit 582a7dd into main May 12, 2023
13 checks passed
@aolfat aolfat deleted the task/cleanup_display_statuses branch May 12, 2023 17:55
@aolfat aolfat temporarily deployed to Integration testing May 12, 2023 17:58 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing May 12, 2023 17:58 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing May 12, 2023 17:58 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing May 12, 2023 17:58 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing May 12, 2023 17:58 — with GitHub Actions Inactive
@aolfat aolfat had a problem deploying to Integration testing May 12, 2023 17:58 — with GitHub Actions Failure
@aolfat aolfat temporarily deployed to Integration testing May 12, 2023 17:59 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants