-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Fix missing executor type in differing fields check for SparkProvider #789
Merged
ahmadnazeri
merged 1 commit into
featureform:main
from
zhilingc:fix-differing-fields-check
May 8, 2023
Merged
[BUGFIX] Fix missing executor type in differing fields check for SparkProvider #789
ahmadnazeri
merged 1 commit into
featureform:main
from
zhilingc:fix-differing-fields-check
May 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhilingc
had a problem deploying
to
Integration testing
May 3, 2023 13:42
— with
GitHub Actions
Failure
zhilingc
had a problem deploying
to
Integration testing
May 3, 2023 13:42
— with
GitHub Actions
Failure
zhilingc
had a problem deploying
to
Integration testing
May 3, 2023 13:42
— with
GitHub Actions
Failure
zhilingc
had a problem deploying
to
Integration testing
May 3, 2023 13:42
— with
GitHub Actions
Failure
zhilingc
had a problem deploying
to
Integration testing
May 3, 2023 13:43
— with
GitHub Actions
Failure
zhilingc
had a problem deploying
to
Integration testing
May 3, 2023 13:43
— with
GitHub Actions
Failure
zhilingc
had a problem deploying
to
Integration testing
May 3, 2023 13:46
— with
GitHub Actions
Failure
Codecov Report
@@ Coverage Diff @@
## main #789 +/- ##
===========================================
- Coverage 59.71% 29.37% -30.34%
===========================================
Files 63 66 +3
Lines 12408 12974 +566
===========================================
- Hits 7409 3811 -3598
- Misses 4232 8881 +4649
+ Partials 767 282 -485
... and 31 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zhilingc
had a problem deploying
to
Integration testing
May 8, 2023 20:14
— with
GitHub Actions
Failure
zhilingc
had a problem deploying
to
Integration testing
May 8, 2023 20:14
— with
GitHub Actions
Failure
zhilingc
had a problem deploying
to
Integration testing
May 8, 2023 20:14
— with
GitHub Actions
Failure
zhilingc
had a problem deploying
to
Integration testing
May 8, 2023 20:14
— with
GitHub Actions
Failure
zhilingc
had a problem deploying
to
Integration testing
May 8, 2023 20:14
— with
GitHub Actions
Failure
zhilingc
had a problem deploying
to
Integration testing
May 8, 2023 20:14
— with
GitHub Actions
Failure
zhilingc
had a problem deploying
to
Integration testing
May 8, 2023 20:23
— with
GitHub Actions
Failure
zhilingc
had a problem deploying
to
Integration testing
May 8, 2023 20:23
— with
GitHub Actions
Failure
zhilingc
had a problem deploying
to
Integration testing
May 8, 2023 20:23
— with
GitHub Actions
Failure
zhilingc
had a problem deploying
to
Integration testing
May 8, 2023 20:23
— with
GitHub Actions
Failure
zhilingc
had a problem deploying
to
Integration testing
May 8, 2023 20:23
— with
GitHub Actions
Failure
zhilingc
had a problem deploying
to
Integration testing
May 8, 2023 20:23
— with
GitHub Actions
Failure
ahmadnazeri
approved these changes
May 8, 2023
sdreyer
pushed a commit
that referenced
this pull request
May 16, 2023
…kProvider (#789) Co-authored-by: zhiling <zhilingc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently unable to update spark provider with generic spark executor due to differing config check missing SparkGeneric as one of its possible executor options. This PR hopefully fixes that issue.
Error thrown by client:
Type of change
Does this correspond to an open issue?
Select type(s) of change
Checklist: