Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix missing executor type in differing fields check for SparkProvider #789

Merged
merged 1 commit into from
May 8, 2023

Conversation

zhilingc
Copy link
Contributor

@zhilingc zhilingc commented May 3, 2023

Description

Currently unable to update spark provider with generic spark executor due to differing config check missing SparkGeneric as one of its possible executor options. This PR hopefully fixes that issue.

Error thrown by client:

> featureform apply definitions.py --insecure
...
...
grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
 status = StatusCode.UNKNOWN
 details = "unknown executor type: SPARK"
 debug_error_string = "UNKNOWN:Error received from peer  {created_time:"2023-05-03T20:47:58.156508+08:00", grpc_status:2, grpc_message:"unknown executor type: SPARK"}"

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • [NA] I have commented my code, particularly in hard-to-understand areas
  • [NA] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #789 (478a797) into main (6f7b498) will decrease coverage by 30.34%.
The diff coverage is 14.35%.

@@             Coverage Diff             @@
##             main     #789       +/-   ##
===========================================
- Coverage   59.71%   29.37%   -30.34%     
===========================================
  Files          63       66        +3     
  Lines       12408    12974      +566     
===========================================
- Hits         7409     3811     -3598     
- Misses       4232     8881     +4649     
+ Partials      767      282      -485     
Impacted Files Coverage Δ
config/config.go 20.00% <0.00%> (-80.00%) ⬇️
coordinator/coordinator.go 0.87% <0.00%> (-41.93%) ⬇️
helpers/compression/compression.go 0.00% <0.00%> (ø)
kubernetes/kubernetes.go 0.00% <0.00%> (-20.68%) ⬇️
provider/bigquery.go 0.00% <0.00%> (-70.19%) ⬇️
provider/filestore.go 12.53% <0.00%> (-30.40%) ⬇️
provider/k8s.go 11.20% <ø> (-19.01%) ⬇️
provider/provider_config/spark_config.go 60.60% <ø> (+3.55%) ⬆️
provider/provider_type/provider_type.go 100.00% <ø> (ø)
provider/redshift.go 0.00% <ø> (-85.25%) ⬇️
... and 7 more

... and 31 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ahmadnazeri ahmadnazeri merged commit 3a2eff8 into featureform:main May 8, 2023
35 of 43 checks passed
sdreyer pushed a commit that referenced this pull request May 16, 2023
…kProvider (#789)

Co-authored-by: zhiling <zhilingc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants