Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix scheduling for KCF #853

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Conversation

aolfat
Copy link
Contributor

@aolfat aolfat commented Jun 7, 2023

Description

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

provider/k8s.go Show resolved Hide resolved
@aolfat aolfat temporarily deployed to Integration testing June 7, 2023 16:23 — with GitHub Actions Inactive
@aolfat aolfat had a problem deploying to Integration testing June 7, 2023 16:23 — with GitHub Actions Failure
@aolfat aolfat had a problem deploying to Integration testing June 7, 2023 16:23 — with GitHub Actions Failure
@aolfat aolfat temporarily deployed to Integration testing June 7, 2023 16:23 — with GitHub Actions Inactive
@aolfat aolfat had a problem deploying to Integration testing June 7, 2023 16:23 — with GitHub Actions Failure
@aolfat aolfat temporarily deployed to Integration testing June 7, 2023 16:24 — with GitHub Actions Inactive
@aolfat aolfat had a problem deploying to Integration testing June 7, 2023 16:27 — with GitHub Actions Failure
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #853 (63106b5) into main (dadd2e0) will increase coverage by 5.51%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
+ Coverage   51.20%   56.72%   +5.51%     
==========================================
  Files          67       67              
  Lines       13578    13587       +9     
==========================================
+ Hits         6953     7707     +754     
+ Misses       5972     5129     -843     
- Partials      653      751      +98     
Impacted Files Coverage Δ
provider/k8s.go 9.51% <0.00%> (+7.43%) ⬆️

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aolfat aolfat temporarily deployed to Integration testing June 7, 2023 18:17 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing June 7, 2023 18:17 — with GitHub Actions Inactive
@aolfat aolfat had a problem deploying to Integration testing June 7, 2023 18:17 — with GitHub Actions Failure
@aolfat aolfat temporarily deployed to Integration testing June 7, 2023 18:17 — with GitHub Actions Inactive
@aolfat aolfat had a problem deploying to Integration testing June 7, 2023 18:17 — with GitHub Actions Failure
@aolfat aolfat temporarily deployed to Integration testing June 7, 2023 18:17 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing June 7, 2023 18:38 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing June 7, 2023 18:38 — with GitHub Actions Inactive
@aolfat aolfat had a problem deploying to Integration testing June 7, 2023 18:38 — with GitHub Actions Failure
@aolfat aolfat temporarily deployed to Integration testing June 7, 2023 18:38 — with GitHub Actions Inactive
@aolfat aolfat had a problem deploying to Integration testing June 7, 2023 18:38 — with GitHub Actions Failure
@aolfat aolfat temporarily deployed to Integration testing June 7, 2023 18:38 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing June 8, 2023 21:09 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing June 8, 2023 21:09 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing June 8, 2023 21:09 — with GitHub Actions Inactive
@aolfat aolfat had a problem deploying to Integration testing June 8, 2023 21:09 — with GitHub Actions Failure
@aolfat aolfat had a problem deploying to Integration testing June 8, 2023 21:09 — with GitHub Actions Failure
@aolfat aolfat temporarily deployed to Integration testing June 8, 2023 21:09 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing June 30, 2023 17:32 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing June 30, 2023 17:32 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing June 30, 2023 17:32 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing June 30, 2023 17:32 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing June 30, 2023 17:32 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing June 30, 2023 17:32 — with GitHub Actions Inactive
@aolfat aolfat had a problem deploying to Integration testing June 30, 2023 17:34 — with GitHub Actions Failure
provider/k8s.go Show resolved Hide resolved
@aolfat aolfat merged commit 45746e8 into main Jun 30, 2023
47 of 48 checks passed
@aolfat aolfat deleted the scheduling/bufix/kcf-scheduling branch June 30, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants