Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinecone as Vector Database Provider #854

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Pinecone as Vector Database Provider #854

merged 3 commits into from
Jul 10, 2023

Conversation

epps
Copy link
Contributor

@epps epps commented Jun 9, 2023

Description

This PR introduces support for Pinecone as a vector database provider.

Remaining items before moving this PR out of Draft:

  • Pinecone API client tests
  • Documentation

Type of change

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@epps epps requested review from sdreyer and simba-git June 9, 2023 00:00
coordinator/Dockerfile.old Outdated Show resolved Hide resolved
@epps epps had a problem deploying to Integration testing June 9, 2023 00:04 — with GitHub Actions Failure
@epps epps had a problem deploying to Integration testing June 9, 2023 00:04 — with GitHub Actions Failure
@epps epps had a problem deploying to Integration testing June 9, 2023 00:04 — with GitHub Actions Failure
@epps epps temporarily deployed to Integration testing June 9, 2023 00:04 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing June 9, 2023 00:04 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing June 9, 2023 00:04 — with GitHub Actions Inactive
@epps epps had a problem deploying to Integration testing June 9, 2023 00:06 — with GitHub Actions Failure
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #854 (3a4ce1d) into main (dadd2e0) will decrease coverage by 1.40%.
The diff coverage is 3.33%.

@@            Coverage Diff             @@
##             main     #854      +/-   ##
==========================================
- Coverage   51.20%   49.80%   -1.40%     
==========================================
  Files          67       69       +2     
  Lines       13578    13881     +303     
==========================================
- Hits         6953     6914      -39     
- Misses       5972     6292     +320     
- Partials      653      675      +22     
Impacted Files Coverage Δ
provider/k8s.go 8.24% <0.00%> (+6.17%) ⬆️
provider/online.go 80.85% <ø> (-14.90%) ⬇️
provider/pinecone.go 0.00% <0.00%> (ø)
provider/provider_type/provider_type.go 100.00% <ø> (ø)
provider/redis.go 31.80% <0.00%> (-45.85%) ⬇️
provider/provider_config/pinecone_config.go 47.61% <47.61%> (ø)
provider/provider.go 87.80% <100.00%> (-7.20%) ⬇️

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

provider/pinecone.go Outdated Show resolved Hide resolved
provider/pinecone.go Outdated Show resolved Hide resolved
@epps epps had a problem deploying to Integration testing June 9, 2023 23:53 — with GitHub Actions Failure
@epps epps had a problem deploying to Integration testing June 9, 2023 23:53 — with GitHub Actions Failure
@epps epps had a problem deploying to Integration testing June 9, 2023 23:53 — with GitHub Actions Failure
@epps epps temporarily deployed to Integration testing June 9, 2023 23:53 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing June 9, 2023 23:53 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing June 9, 2023 23:53 — with GitHub Actions Inactive
@epps epps marked this pull request as ready for review June 9, 2023 23:55
@epps epps had a problem deploying to Integration testing June 9, 2023 23:56 — with GitHub Actions Failure
client/src/featureform/register.py Outdated Show resolved Hide resolved
provider/pinecone.go Show resolved Hide resolved
provider/provider_config/pinecone_config.go Outdated Show resolved Hide resolved
@epps epps had a problem deploying to Integration testing June 12, 2023 17:44 — with GitHub Actions Failure
@epps epps had a problem deploying to Integration testing June 12, 2023 17:44 — with GitHub Actions Failure
@epps epps had a problem deploying to Integration testing June 12, 2023 17:44 — with GitHub Actions Failure
@epps epps temporarily deployed to Integration testing June 12, 2023 17:44 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing June 12, 2023 17:44 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing June 12, 2023 17:45 — with GitHub Actions Inactive
@epps epps had a problem deploying to Integration testing June 12, 2023 17:47 — with GitHub Actions Failure
@epps epps temporarily deployed to Integration testing June 21, 2023 17:10 — with GitHub Actions Inactive
@epps epps had a problem deploying to Integration testing June 21, 2023 17:10 — with GitHub Actions Failure
@epps epps temporarily deployed to Integration testing June 21, 2023 17:10 — with GitHub Actions Inactive
@epps epps had a problem deploying to Integration testing June 21, 2023 17:10 — with GitHub Actions Failure
@epps epps temporarily deployed to Integration testing June 21, 2023 17:10 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing June 21, 2023 17:10 — with GitHub Actions Inactive
@epps epps had a problem deploying to Integration testing June 21, 2023 17:11 — with GitHub Actions Failure
@epps epps temporarily deployed to Integration testing July 8, 2023 18:05 — with GitHub Actions Inactive
@epps epps had a problem deploying to Integration testing July 8, 2023 18:05 — with GitHub Actions Failure
@epps epps temporarily deployed to Integration testing July 8, 2023 18:05 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing July 8, 2023 18:06 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing July 8, 2023 18:06 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing July 8, 2023 18:06 — with GitHub Actions Inactive
@sdreyer sdreyer had a problem deploying to Integration testing July 8, 2023 18:54 — with GitHub Actions Failure
@sdreyer sdreyer temporarily deployed to Integration testing July 8, 2023 18:54 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing July 8, 2023 18:54 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing July 8, 2023 18:54 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing July 8, 2023 18:54 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing July 8, 2023 18:54 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing July 8, 2023 18:58 — with GitHub Actions Inactive
@sdreyer sdreyer merged commit 7f13eb3 into main Jul 10, 2023
44 of 45 checks passed
@sdreyer sdreyer deleted the feature/pinecone branch July 10, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants