Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Table Definitions #858

Merged
merged 85 commits into from
Jun 16, 2023
Merged

Source Table Definitions #858

merged 85 commits into from
Jun 16, 2023

Conversation

anthonylasso
Copy link
Contributor

@anthonylasso anthonylasso commented Jun 9, 2023 •
edited

Description

This PR enables users to view the Source table definition with the first 150 row values. This feature works across in both hosted mode and localmode.

Example Video:

localmode

Screen.Recording.2023-06-15.at.2.32.04.PM.mov

Error Cases:

Missing Params
Screenshot 2023-06-15 at 3 10 34 PM

General Errors
Screenshot 2023-06-15 at 3 10 23 PM

Unit Tests:

Screenshot 2023-06-09 at 6 08 06 PM

Example Endpoint Response: /data/sourcedata

example.txt

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@anthonylasso
configure for version display
2925316
@anthonylasso
Merge branch 'main' into feature/812/featureform-version
60854f9
@anthonylasso
chore
d5b08cf
@anthonylasso
fix side nav clipping
9a851e7 
center page content correctly
@anthonylasso
return a version map
861901d
@anthonylasso
include topBar unit test
2354be7 
-rename "__tests__" directory to "__test__"
@anthonylasso
Revert "include topBar unit test"
f835071 
This reverts commit 2354be7.
@anthonylasso
Create topBar.test.js
3389b15
@anthonylasso
Update SearchBar.js
22520ab
@anthonylasso
test fix
1c4c9f6
@anthonylasso
fix pathing on the resource list view
e3308e4 
-use the passed in validated prop instead of the router query (which the user can change)
@anthonylasso
pr chore
a14fc50
@anthonylasso
swap version home to use global.version
9840d37
@anthonylasso
update local dash
20321eb
@anthonylasso
redo version text
548576c
@anthonylasso
add cli version cmd + test
81c7986
@anthonylasso
initial edits
b69e642 
-match prop names and order for metadata
@anthonylasso
chore
cea6365
@anthonylasso
Merge branch 'main' into feature/822/SourceVariant
b9f3b80
@anthonylasso
expand SourceShallowMap() props + unit test
f72ac2e 
-the conversion method SourceShallowMap() now returns extra properties to the caller
-refactor metadata types out of main and into metadata package
-include unit test
-note: over time main needs to have these extra types moved into their appropriate packages.
@anthonylasso
Merge branch 'main' into feature/812/featureform-version
014a501
@anthonylasso
include cluster version + edit unit test
ad5d65c
@anthonylasso
chore
92b7d0a
@anthonylasso
Update e2e.py
e126ed2 
-may need to remove millisecond timestamp from the return (not useful to the user and will cause tests to break)
@anthonylasso
chore
a55525f
@anthonylasso
rework the version fetch logic + tests
8f53355 
simplifies the version fetching logic.
@anthonylasso
chore
75b8ef7
@anthonylasso
Merge branch 'feature/812/featureform-version' into feature/822/Sourc…
9119bd4 
…eVariant
@anthonylasso
typo and format change
0fcb688
@anthonylasso
chore
95c56f0
@anthonylasso anthonylasso temporarily deployed to Integration testing June 16, 2023 14:52 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing June 16, 2023 14:52 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing June 16, 2023 14:52 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing June 16, 2023 19:00 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing June 16, 2023 19:07 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing June 16, 2023 19:07 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing June 16, 2023 19:07 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing June 16, 2023 19:07 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing June 16, 2023 20:00 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing June 16, 2023 20:01 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing June 16, 2023 20:01 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing June 16, 2023 20:01 — with GitHub Actions Inactive
@anthonylasso anthonylasso merged commit 81b21b1 into main Jun 16, 2023
42 of 45 checks passed
@anthonylasso anthonylasso deleted the feature/sourceTableModal branch June 16, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmadnazeri ahmadnazeri ahmadnazeri approved these changes

@sdreyer sdreyer sdreyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anthonylasso @sdreyer @ahmadnazeri