Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to read entire directory #869

Merged
merged 7 commits into from
Jun 15, 2023
Merged

Conversation

sdreyer
Copy link
Collaborator

@sdreyer sdreyer commented Jun 14, 2023

Description

using ff.register_directory() will read all files from a directory into a dataframe

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@sdreyer sdreyer temporarily deployed to Integration testing June 14, 2023 22:01 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #869 (35cd067) into main (6f7b498) will decrease coverage by 5.66%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #869      +/-   ##
==========================================
- Coverage   59.71%   54.05%   -5.66%     
==========================================
  Files          63       67       +4     
  Lines       12408    13578    +1170     
==========================================
- Hits         7409     7340      -69     
- Misses       4232     5525    +1293     
+ Partials      767      713      -54     
Impacted Files Coverage Δ
helpers/compression/compression.go 0.00% <ø> (ø)
helpers/env.go 88.23% <ø> (-11.77%) ⬇️
kubernetes/kubernetes.go 20.42% <ø> (-0.26%) ⬇️
metadata/client.go 84.35% <ø> (+1.12%) ⬆️
metadata/metadata.go 71.18% <ø> (+2.21%) ⬆️
provider/bigquery.go 70.00% <ø> (-0.18%) ⬇️
provider/blob_online.go 0.00% <ø> (-69.07%) ⬇️
provider/cassandra.go 72.15% <ø> (ø)
provider/dynamodb.go 18.69% <ø> (-56.10%) ⬇️
provider/filepath.go 59.55% <ø> (ø)
... and 15 more

... and 19 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sdreyer sdreyer temporarily deployed to Integration testing June 14, 2023 22:06 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing June 14, 2023 22:07 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing June 14, 2023 22:16 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing June 14, 2023 22:16 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing June 14, 2023 22:16 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing June 14, 2023 22:16 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing June 14, 2023 22:16 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing June 15, 2023 00:29 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing June 15, 2023 00:29 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing June 15, 2023 02:06 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing June 15, 2023 02:06 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing June 15, 2023 02:07 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing June 15, 2023 02:19 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing June 15, 2023 02:19 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing June 15, 2023 02:19 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing June 15, 2023 02:43 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing June 15, 2023 02:43 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing June 15, 2023 02:43 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing June 15, 2023 02:43 — with GitHub Actions Inactive
@sdreyer sdreyer merged commit 8d3a248 into main Jun 15, 2023
41 of 45 checks passed
@sdreyer sdreyer deleted the feature/read-directory-of-files branch June 15, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants