Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional Inference store in localmode #872

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

sdreyer
Copy link
Collaborator

@sdreyer sdreyer commented Jun 16, 2023

Description

If inference store is not specified, it defaults to local in localmode and errors in hosted

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

Copy link
Contributor

@epps epps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@sdreyer sdreyer force-pushed the feature/localmode-inference-default branch from 13bbb5a to 8698cbf Compare June 16, 2023 19:59
@sdreyer sdreyer temporarily deployed to Integration testing June 16, 2023 20:02 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing June 16, 2023 20:02 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing June 16, 2023 20:02 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing June 16, 2023 20:02 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #872 (8698cbf) into main (6f7b498) will decrease coverage by 8.51%.
The diff coverage is 35.71%.

@@            Coverage Diff             @@
##             main     #872      +/-   ##
==========================================
- Coverage   59.71%   51.20%   -8.51%     
==========================================
  Files          63       67       +4     
  Lines       12408    13578    +1170     
==========================================
- Hits         7409     6953     -456     
- Misses       4232     5972    +1740     
+ Partials      767      653     -114     
Impacted Files Coverage Δ
helpers/compression/compression.go 0.00% <ø> (ø)
helpers/env.go 88.23% <ø> (-11.77%) ⬇️
kubernetes/kubernetes.go 20.42% <ø> (-0.26%) ⬇️
metadata/client.go 84.11% <ø> (+0.88%) ⬆️
metadata/metadata.go 71.18% <ø> (+2.21%) ⬆️
provider/bigquery.go 70.00% <ø> (-0.18%) ⬇️
provider/blob_online.go 0.00% <ø> (-69.07%) ⬇️
provider/cassandra.go 72.15% <ø> (ø)
provider/dynamodb.go 18.69% <ø> (-56.10%) ⬇️
provider/filepath.go 59.55% <ø> (ø)
... and 15 more

... and 20 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@epps epps merged commit c954539 into main Jun 16, 2023
43 of 47 checks passed
@epps epps deleted the feature/localmode-inference-default branch June 16, 2023 20:41
sdreyer added a commit that referenced this pull request Jun 16, 2023
sdreyer added a commit that referenced this pull request Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants