Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: changing "default" to "" #879

Merged
merged 1 commit into from
Jun 17, 2023
Merged

Bugfix: changing "default" to "" #879

merged 1 commit into from
Jun 17, 2023

Conversation

ahmadnazeri
Copy link
Contributor

@ahmadnazeri ahmadnazeri commented Jun 17, 2023 •
edited

Description

Changing "default" to "" for the variants.

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@ahmadnazeri ahmadnazeri marked this pull request as ready for review June 17, 2023 00:07
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing June 17, 2023 00:09 — with GitHub Actions Inactive
epps
epps approved these changes Jun 17, 2023
View reviewed changes
Copy link
Contributor

@epps epps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOLO

@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing June 17, 2023 00:09 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing June 17, 2023 00:09 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing June 17, 2023 00:09 — with GitHub Actions Inactive
@epps epps merged commit a1363e2 into feature/ucb Jun 17, 2023
24 of 42 checks passed
@epps epps deleted the bugfix/remove_default_variants branch June 17, 2023 00:09
simba-git pushed a commit that referenced this pull request Jun 17, 2023
@ahmadnazeri @simba-git
Bugfix: changing "default" to "" (#879)
d64548f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epps epps epps approved these changes

@aolfat aolfat Awaiting requested review from aolfat

@sdreyer sdreyer Awaiting requested review from sdreyer

@anthonylasso anthonylasso Awaiting requested review from anthonylasso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahmadnazeri @epps