Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Accepting Feature object or (name, variant) tuple for nearest #885

Merged
merged 2 commits into from
Jun 17, 2023

Conversation

ahmadnazeri
Copy link
Contributor

Description

Modified nearest in Client to accept Feature object or (name, variant) tuple.

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@ahmadnazeri ahmadnazeri requested a review from epps June 17, 2023 02:30
@ahmadnazeri ahmadnazeri marked this pull request as ready for review June 17, 2023 02:31
Copy link
Contributor

@epps epps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing June 17, 2023 02:34 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing June 17, 2023 02:35 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing June 17, 2023 02:35 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (feature/ucb@0a438d4). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             feature/ucb     #885   +/-   ##
==============================================
  Coverage               ?   53.85%           
==============================================
  Files                  ?       67           
  Lines                  ?    13578           
  Branches               ?        0           
==============================================
  Hits                   ?     7312           
  Misses                 ?     5552           
  Partials               ?      714           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@epps epps merged commit b5f65d6 into feature/ucb Jun 17, 2023
26 of 45 checks passed
@epps epps deleted the bugfix/nearest_accept_tuple_object branch June 17, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants