Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds back missing weaviate provider config implementation #899

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

epps
Copy link
Contributor

@epps epps commented Jun 22, 2023

Description

This PR fixes some missing provider config implementation for Weaviate (localmode).

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@epps epps requested a review from sdreyer June 22, 2023 20:57
@epps epps had a problem deploying to Integration testing June 22, 2023 21:00 — with GitHub Actions Failure
@epps epps temporarily deployed to Integration testing June 22, 2023 21:00 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing June 22, 2023 21:00 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing June 22, 2023 21:00 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing June 22, 2023 21:00 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing June 22, 2023 21:00 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #899 (a9a9b4e) into main (dadd2e0) will increase coverage by 5.51%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #899      +/-   ##
==========================================
+ Coverage   51.20%   56.72%   +5.51%     
==========================================
  Files          67       67              
  Lines       13578    13587       +9     
==========================================
+ Hits         6953     7707     +754     
+ Misses       5972     5129     -843     
- Partials      653      751      +98     
Impacted Files Coverage Δ
provider/k8s.go 9.51% <0.00%> (+7.43%) ⬆️

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@epps epps temporarily deployed to Integration testing June 22, 2023 21:04 — with GitHub Actions Inactive
@epps epps force-pushed the bugfix/weaviate-provider-config branch from 648cd95 to a9a9b4e Compare June 30, 2023 22:10
@epps epps requested a review from sdreyer June 30, 2023 22:12
@epps epps temporarily deployed to Integration testing June 30, 2023 22:14 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing June 30, 2023 22:14 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing June 30, 2023 22:14 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing June 30, 2023 22:14 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing June 30, 2023 22:14 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing June 30, 2023 22:14 — with GitHub Actions Inactive
@epps epps had a problem deploying to Integration testing June 30, 2023 22:17 — with GitHub Actions Failure
@sdreyer sdreyer merged commit 60d6273 into main Jul 7, 2023
44 of 45 checks passed
@sdreyer sdreyer deleted the bugfix/weaviate-provider-config branch July 7, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants