-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds back missing weaviate provider config implementation #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epps
had a problem deploying
to
Integration testing
June 22, 2023 21:00
— with
GitHub Actions
Failure
Codecov Report
@@ Coverage Diff @@
## main #899 +/- ##
==========================================
+ Coverage 51.20% 56.72% +5.51%
==========================================
Files 67 67
Lines 13578 13587 +9
==========================================
+ Hits 6953 7707 +754
+ Misses 5972 5129 -843
- Partials 653 751 +98
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sdreyer
reviewed
Jun 26, 2023
epps
force-pushed
the
bugfix/weaviate-provider-config
branch
from
June 30, 2023 22:10
648cd95
to
a9a9b4e
Compare
epps
had a problem deploying
to
Integration testing
June 30, 2023 22:17
— with
GitHub Actions
Failure
sdreyer
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some missing provider config implementation for Weaviate (localmode).
Type of change
Does this correspond to an open issue?
Select type(s) of change
Checklist: