Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Formatter in Dashboard. #915

Merged
merged 46 commits into from
Jul 9, 2023
Merged

SQL Formatter in Dashboard. #915

merged 46 commits into from
Jul 9, 2023

Conversation

anthonylasso
Copy link
Contributor

Description

This MR will display sql based transformations in a formatted way.

If the formatting fails, the original raw string will be used instead.

Screenshot 2023-07-07 at 5 49 56 PM

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@anthonylasso anthonylasso temporarily deployed to Integration testing July 8, 2023 20:50 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 8, 2023 20:50 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 8, 2023 20:50 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 8, 2023 20:50 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 8, 2023 20:50 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 8, 2023 20:50 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Merging #915 (9cf1b23) into main (dadd2e0) will increase coverage by 5.54%.
The diff coverage is 55.85%.

@@            Coverage Diff             @@
##             main     #915      +/-   ##
==========================================
+ Coverage   51.20%   56.74%   +5.54%     
==========================================
  Files          67       67              
  Lines       13578    13595      +17     
==========================================
+ Hits         6953     7715     +762     
+ Misses       5972     5129     -843     
- Partials      653      751      +98     
Impacted Files Coverage Δ
provider/k8s.go 9.51% <0.00%> (+7.43%) ⬆️
metadata/metadata.go 71.18% <69.23%> (+0.27%) ⬆️
metadata/etcd.go 64.30% <89.65%> (ø)
metadata/client.go 84.45% <100.00%> (+0.09%) ⬆️
metadata/updates.go 92.50% <100.00%> (ø)

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sdreyer sdreyer merged commit da9797b into main Jul 9, 2023
43 of 45 checks passed
@sdreyer sdreyer deleted the feature/sqlformat branch July 9, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants