Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/pinecone casting #917

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Hotfix/pinecone casting #917

merged 2 commits into from
Jul 10, 2023

Conversation

sdreyer
Copy link
Collaborator

@sdreyer sdreyer commented Jul 10, 2023

Description

Fixes interface for vector database

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@sdreyer sdreyer temporarily deployed to Integration testing July 10, 2023 17:37 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing July 10, 2023 17:37 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing July 10, 2023 17:37 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing July 10, 2023 17:37 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #917 (95c3e3a) into main (dadd2e0) will increase coverage by 0.87%.
The diff coverage is 17.93%.

@@            Coverage Diff             @@
##             main     #917      +/-   ##
==========================================
+ Coverage   51.20%   52.08%   +0.87%     
==========================================
  Files          67       69       +2     
  Lines       13578    13889     +311     
==========================================
+ Hits         6953     7234     +281     
+ Misses       5972     5924      -48     
- Partials      653      731      +78     
Impacted Files Coverage Δ
provider/k8s.go 26.88% <0.00%> (+24.80%) ⬆️
provider/online.go 80.85% <ø> (-14.90%) ⬇️
provider/pinecone.go 0.00% <0.00%> (ø)
provider/provider_type/provider_type.go 100.00% <ø> (ø)
provider/redis.go 31.80% <0.00%> (-45.85%) ⬇️
provider/provider_config/pinecone_config.go 47.61% <47.61%> (ø)
metadata/metadata.go 71.18% <69.23%> (+0.27%) ⬆️
metadata/etcd.go 64.30% <89.65%> (ø)
metadata/client.go 84.45% <100.00%> (+0.09%) ⬆️
metadata/updates.go 92.50% <100.00%> (ø)
... and 1 more

... and 15 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sdreyer sdreyer temporarily deployed to Integration testing July 10, 2023 17:55 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing July 10, 2023 17:55 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing July 10, 2023 17:55 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing July 10, 2023 17:55 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing July 10, 2023 18:25 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing July 10, 2023 18:25 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing July 10, 2023 18:25 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing July 10, 2023 18:25 — with GitHub Actions Inactive
@sdreyer sdreyer requested a review from epps July 10, 2023 20:09
@sdreyer sdreyer marked this pull request as ready for review July 10, 2023 20:09
Copy link
Contributor

@epps epps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this is the correct change. Thank you for catching this!

@sdreyer sdreyer merged commit 8720694 into main Jul 10, 2023
39 of 45 checks passed
@sdreyer sdreyer deleted the hotfix/pinecone-casting branch July 10, 2023 20:10
sdreyer added a commit that referenced this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants