Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Dataframe transformation #926

Merged
merged 22 commits into from
Aug 16, 2023
Merged

Conversation

anthonylasso
Copy link
Contributor

@anthonylasso anthonylasso commented Jul 19, 2023

Description

This PR adds a new field source_text to the DFTransformation proto and propagates it throughout the backend. The source_text value is stored in a new table called source_variant_text. This fixes an issue where the dashboard would display a binary string.

Now users can correctly read the transformation function.

Request for Comment

before
Screenshot 2023-07-20 at 3 56 43 PM

after
Screenshot 2023-07-20 at 3 57 02 PM

source_variant_text table

Screenshot 2023-08-01 at 3 33 43 PM

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@anthonylasso anthonylasso temporarily deployed to Integration testing July 19, 2023 22:25 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 19, 2023 22:25 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 19, 2023 22:25 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 19, 2023 22:25 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #926 (7eadb57) into main (2bd119f) will decrease coverage by 2.13%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #926      +/-   ##
==========================================
- Coverage   57.18%   55.05%   -2.13%     
==========================================
  Files          72       72              
  Lines       14153    14158       +5     
==========================================
- Hits         8093     7795     -298     
- Misses       5249     5605     +356     
+ Partials      811      758      -53     
Files Changed Coverage Δ
metadata/client.go 84.11% <0.00%> (-0.34%) ⬇️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anthonylasso anthonylasso temporarily deployed to Integration testing July 20, 2023 21:11 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 20, 2023 21:11 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 20, 2023 21:11 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 20, 2023 21:11 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 20, 2023 21:11 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 20, 2023 21:51 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 20, 2023 21:51 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 20, 2023 21:51 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 20, 2023 21:51 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 20, 2023 21:51 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 20, 2023 22:15 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 20, 2023 22:15 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 14, 2023 22:03 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 14, 2023 22:03 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 14, 2023 22:03 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 14, 2023 22:03 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 14, 2023 22:19 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 14, 2023 22:19 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 14, 2023 22:19 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 14, 2023 22:19 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 14, 2023 22:19 — with GitHub Actions Inactive
@anthonylasso
Copy link
Contributor Author

@aolfat I looked and didn't find anything suitable.

@anthonylasso anthonylasso temporarily deployed to Integration testing August 16, 2023 20:27 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 16, 2023 20:27 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 16, 2023 20:27 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 16, 2023 20:27 — with GitHub Actions Inactive
@anthonylasso anthonylasso merged commit 0adc488 into main Aug 16, 2023
30 of 47 checks passed
@anthonylasso anthonylasso deleted the bugfix/anthony/dataframetransform branch August 16, 2023 20:28
@anthonylasso anthonylasso self-assigned this Aug 17, 2023
sdreyer pushed a commit that referenced this pull request Aug 17, 2023
Co-authored-by: RedLeader16 <34227093+RedLeader16@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants