Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard metadata variant bugfix #933

Merged
merged 4 commits into from
Aug 14, 2023
Merged

Dashboard metadata variant bugfix #933

merged 4 commits into from
Aug 14, 2023

Conversation

anthonylasso
Copy link
Contributor

@anthonylasso anthonylasso commented Jul 25, 2023

Description

This PR catches and warns the user when a default variant is not present in the variant list. The resource list will render and allow the user to continue to use the app (instead of a blank screen)

Bad response example

Screenshot 2023-07-25 at 2 27 58 PM

user warning

Screenshot 2023-07-25 at 4 51 09 PM

unit test

Screenshot 2023-07-25 at 5 08 27 PM

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@anthonylasso anthonylasso temporarily deployed to Integration testing July 25, 2023 22:20 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 25, 2023 22:20 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 25, 2023 22:20 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 25, 2023 22:20 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #933 (29c5752) into main (8b73977) will decrease coverage by 19.83%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #933       +/-   ##
===========================================
- Coverage   45.04%   25.22%   -19.83%     
===========================================
  Files         107       72       -35     
  Lines       19187    14153     -5034     
===========================================
- Hits         8643     3570     -5073     
- Misses       9934    10337      +403     
+ Partials      610      246      -364     

see 66 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anthonylasso anthonylasso temporarily deployed to Integration testing August 10, 2023 17:42 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 10, 2023 17:42 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 10, 2023 17:42 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 10, 2023 17:42 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 14, 2023 22:03 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 14, 2023 22:03 — with GitHub Actions Inactive
@anthonylasso anthonylasso merged commit 2bd119f into main Aug 14, 2023
15 of 16 checks passed
@anthonylasso anthonylasso deleted the bugfix/missingVariant branch August 14, 2023 22:12
@anthonylasso anthonylasso temporarily deployed to Integration testing August 14, 2023 22:16 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 14, 2023 22:16 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 14, 2023 22:16 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 14, 2023 22:16 — with GitHub Actions Inactive
sdreyer pushed a commit that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants