Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table row sizing #937

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Fix table row sizing #937

merged 2 commits into from
Jul 31, 2023

Conversation

anthonylasso
Copy link
Contributor

@anthonylasso anthonylasso commented Jul 27, 2023

Description

This PR sets a default pageSize for the main resource tables to 10, and also decouples the variant length from the sub tables.

primary table
Defaults to 10 records.
Screenshot 2023-07-27 at 2 23 37 PM

sub variant table
Dynamically grows to a max of 10 records before paging.
Screenshot 2023-07-27 at 2 23 46 PM

entity page sub table
image

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@anthonylasso anthonylasso temporarily deployed to Integration testing July 27, 2023 19:35 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 27, 2023 19:35 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 27, 2023 19:36 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 27, 2023 19:36 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 27, 2023 19:36 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #937 (1569092) into main (dadd2e0) will increase coverage by 4.88%.
Report is 19 commits behind head on main.
The diff coverage is 34.64%.

@@            Coverage Diff             @@
##             main     #937      +/-   ##
==========================================
+ Coverage   51.20%   56.09%   +4.88%     
==========================================
  Files          67       69       +2     
  Lines       13578    13889     +311     
==========================================
+ Hits         6953     7791     +838     
+ Misses       5972     5339     -633     
- Partials      653      759     +106     
Files Changed Coverage Δ
provider/k8s.go 9.51% <0.00%> (+7.43%) ⬆️
provider/online.go 95.74% <ø> (ø)
provider/provider_type/provider_type.go 100.00% <ø> (ø)
provider/pinecone.go 22.05% <22.05%> (ø)
metadata/metadata.go 71.18% <69.23%> (+0.27%) ⬆️
provider/provider_config/pinecone_config.go 76.19% <76.19%> (ø)
metadata/etcd.go 64.30% <89.65%> (ø)
metadata/client.go 84.21% <100.00%> (-0.14%) ⬇️
metadata/updates.go 92.50% <100.00%> (ø)
provider/provider.go 95.12% <100.00%> (+0.12%) ⬆️
... and 1 more

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anthonylasso anthonylasso temporarily deployed to Integration testing July 27, 2023 20:16 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 27, 2023 20:16 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 27, 2023 20:16 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 27, 2023 20:16 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing July 27, 2023 20:16 — with GitHub Actions Inactive
@anthonylasso anthonylasso merged commit 930f58f into main Jul 31, 2023
49 of 52 checks passed
@anthonylasso anthonylasso deleted the feature/tableEdits branch July 31, 2023 16:47
sdreyer pushed a commit that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants