-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix table row sizing #937
Merged
Merged
Fix table row sizing #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonylasso
temporarily deployed
to
Integration testing
July 27, 2023 19:35
— with
GitHub Actions
Inactive
anthonylasso
had a problem deploying
to
Integration testing
July 27, 2023 19:35
— with
GitHub Actions
Failure
anthonylasso
temporarily deployed
to
Integration testing
July 27, 2023 19:35
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
July 27, 2023 19:36
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
July 27, 2023 19:36
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
July 27, 2023 19:36
— with
GitHub Actions
Inactive
Codecov Report
@@ Coverage Diff @@
## main #937 +/- ##
==========================================
+ Coverage 51.20% 56.09% +4.88%
==========================================
Files 67 69 +2
Lines 13578 13889 +311
==========================================
+ Hits 6953 7791 +838
+ Misses 5972 5339 -633
- Partials 653 759 +106
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
anthonylasso
had a problem deploying
to
Integration testing
July 27, 2023 19:39
— with
GitHub Actions
Error
anthonylasso
temporarily deployed
to
Integration testing
July 27, 2023 20:16
— with
GitHub Actions
Inactive
anthonylasso
had a problem deploying
to
Integration testing
July 27, 2023 20:16
— with
GitHub Actions
Failure
anthonylasso
temporarily deployed
to
Integration testing
July 27, 2023 20:16
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
July 27, 2023 20:16
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
July 27, 2023 20:16
— with
GitHub Actions
Inactive
anthonylasso
temporarily deployed
to
Integration testing
July 27, 2023 20:16
— with
GitHub Actions
Inactive
anthonylasso
had a problem deploying
to
Integration testing
July 27, 2023 20:22
— with
GitHub Actions
Failure
sdreyer
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR sets a default
pageSize
for the main resource tables to 10, and also decouples the variant length from the sub tables.primary table
Defaults to 10 records.
sub variant table
Dynamically grows to a max of 10 records before paging.
entity page sub table
Type of change
Does this correspond to an open issue?
Select type(s) of change
Checklist: