Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest Coverage #940

Merged
merged 3 commits into from
Aug 2, 2023
Merged

pytest Coverage #940

merged 3 commits into from
Aug 2, 2023

Conversation

epps
Copy link
Contributor

@epps epps commented Jul 28, 2023

Description

This PR is an initial step towards publishing a code coverage report for the Python client.

Type of change

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test coverage

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@epps epps requested review from aolfat and sdreyer July 28, 2023 16:00
@epps epps temporarily deployed to Integration testing July 28, 2023 16:02 — with GitHub Actions Inactive
@epps epps had a problem deploying to Integration testing July 28, 2023 16:02 — with GitHub Actions Failure
@epps epps temporarily deployed to Integration testing July 28, 2023 16:02 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing July 28, 2023 16:02 — with GitHub Actions Inactive
@epps epps had a problem deploying to Integration testing July 28, 2023 16:02 — with GitHub Actions Failure
@epps epps temporarily deployed to Integration testing July 28, 2023 16:02 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #940 (9c78ab9) into main (dadd2e0) will increase coverage by 6.52%.
Report is 21 commits behind head on main.
The diff coverage is 35.74%.

@@            Coverage Diff             @@
##             main     #940      +/-   ##
==========================================
+ Coverage   51.20%   57.73%   +6.52%     
==========================================
  Files          67      104      +37     
  Lines       13578    18923    +5345     
==========================================
+ Hits         6953    10925    +3972     
- Misses       5972     7187    +1215     
- Partials      653      811     +158     
Files Changed Coverage Δ
client/src/featureform/cli.py 46.92% <0.00%> (ø)
provider/k8s.go 26.88% <0.00%> (+24.80%) ⬆️
provider/online.go 95.74% <ø> (ø)
provider/provider_type/provider_type.go 100.00% <ø> (ø)
client/src/featureform/dashboard_metadata.py 19.86% <9.70%> (ø)
provider/pinecone.go 22.05% <22.05%> (ø)
client/src/featureform/resources.py 65.85% <33.33%> (ø)
client/src/featureform/serving.py 52.94% <56.25%> (ø)
client/src/featureform/sqlite_metadata.py 88.30% <58.33%> (ø)
client/src/featureform/client.py 62.85% <66.66%> (ø)
... and 12 more

... and 37 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@epps epps had a problem deploying to Integration testing July 28, 2023 16:06 — with GitHub Actions Failure
@epps epps temporarily deployed to Integration testing July 31, 2023 17:09 — with GitHub Actions Inactive
@epps epps had a problem deploying to Integration testing July 31, 2023 17:09 — with GitHub Actions Failure
@epps epps temporarily deployed to Integration testing July 31, 2023 17:09 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing July 31, 2023 17:09 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing July 31, 2023 17:10 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing July 31, 2023 17:10 — with GitHub Actions Inactive
@epps epps had a problem deploying to Integration testing July 31, 2023 17:12 — with GitHub Actions Failure
@epps epps temporarily deployed to Integration testing July 31, 2023 18:28 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing July 31, 2023 18:35 — with GitHub Actions Inactive
@epps epps had a problem deploying to Integration testing July 31, 2023 18:35 — with GitHub Actions Failure
@epps epps temporarily deployed to Integration testing July 31, 2023 18:35 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing July 31, 2023 18:35 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing July 31, 2023 18:35 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing July 31, 2023 18:35 — with GitHub Actions Inactive
@epps epps had a problem deploying to Integration testing July 31, 2023 18:38 — with GitHub Actions Failure
@epps epps had a problem deploying to Integration testing July 31, 2023 19:31 — with GitHub Actions Failure
@epps epps temporarily deployed to Integration testing July 31, 2023 19:31 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing July 31, 2023 19:31 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing July 31, 2023 19:31 — with GitHub Actions Inactive
@epps epps had a problem deploying to Integration testing July 31, 2023 19:32 — with GitHub Actions Failure
@epps epps temporarily deployed to Integration testing July 31, 2023 19:32 — with GitHub Actions Inactive
@epps epps had a problem deploying to Integration testing July 31, 2023 19:35 — with GitHub Actions Failure
@epps epps temporarily deployed to Integration testing July 31, 2023 20:15 — with GitHub Actions Inactive
@epps epps had a problem deploying to Integration testing July 31, 2023 20:15 — with GitHub Actions Failure
@epps epps temporarily deployed to Integration testing July 31, 2023 20:15 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing July 31, 2023 20:15 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing July 31, 2023 20:15 — with GitHub Actions Inactive
@epps epps had a problem deploying to Integration testing July 31, 2023 20:15 — with GitHub Actions Failure
@epps epps had a problem deploying to Integration testing July 31, 2023 20:19 — with GitHub Actions Failure
@sdreyer sdreyer merged commit b7c0847 into main Aug 2, 2023
49 of 53 checks passed
@sdreyer sdreyer deleted the task/pytest-refactoring branch August 2, 2023 02:28
sdreyer pushed a commit that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants