Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Resource names to ResourceVariant #941

Merged
merged 12 commits into from
Aug 16, 2023
Merged

Conversation

aolfat
Copy link
Contributor

@aolfat aolfat commented Jul 28, 2023

Description

Change Resource classes to ResourceVariant

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@aolfat aolfat had a problem deploying to Integration testing July 28, 2023 20:47 — with GitHub Actions Failure
@aolfat aolfat temporarily deployed to Integration testing July 28, 2023 20:47 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing July 28, 2023 20:47 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing July 28, 2023 20:47 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing July 28, 2023 20:47 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing July 28, 2023 20:47 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #941 (80377ce) into main (2bd119f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #941   +/-   ##
=======================================
  Coverage   57.18%   57.18%           
=======================================
  Files          72       72           
  Lines       14153    14153           
=======================================
+ Hits         8093     8094    +1     
  Misses       5249     5249           
+ Partials      811      810    -1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aolfat aolfat had a problem deploying to Integration testing July 28, 2023 20:50 — with GitHub Actions Failure
@aolfat aolfat temporarily deployed to Integration testing August 2, 2023 07:13 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 2, 2023 07:13 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 2, 2023 07:13 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 2, 2023 07:30 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 2, 2023 07:30 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 2, 2023 07:30 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 2, 2023 07:30 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 2, 2023 07:30 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 2, 2023 07:46 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 2, 2023 18:30 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 2, 2023 18:30 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 2, 2023 18:30 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 2, 2023 18:30 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 2, 2023 18:41 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 2, 2023 18:41 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 2, 2023 18:41 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 2, 2023 18:41 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 2, 2023 18:41 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 16, 2023 17:41 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 16, 2023 17:41 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 16, 2023 17:41 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 16, 2023 17:42 — with GitHub Actions Inactive
Copy link
Contributor

@epps epps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aolfat aolfat merged commit 8a37d66 into main Aug 16, 2023
48 of 53 checks passed
@aolfat aolfat deleted the refactor/name_variant_renmaing branch August 16, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants