Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: KCF doesn't read csv files feature registered on source #943

Merged
merged 4 commits into from
Aug 4, 2023

Conversation

aolfat
Copy link
Contributor

@aolfat aolfat commented Aug 2, 2023

Description

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@aolfat aolfat marked this pull request as draft August 2, 2023 23:17
@aolfat aolfat temporarily deployed to Deployment August 2, 2023 23:19 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Deployment August 2, 2023 23:19 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Deployment August 2, 2023 23:19 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Deployment August 2, 2023 23:19 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Deployment August 2, 2023 23:19 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Deployment August 2, 2023 23:19 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Deployment August 2, 2023 23:19 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Deployment August 2, 2023 23:19 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Deployment August 2, 2023 23:20 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Deployment August 2, 2023 23:20 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Deployment August 2, 2023 23:20 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 2, 2023 23:22 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 2, 2023 23:22 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 2, 2023 23:22 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 2, 2023 23:22 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 2, 2023 23:22 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #943 (8bfd111) into main (dadd2e0) will increase coverage by 19.53%.
Report is 22 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #943       +/-   ##
===========================================
+ Coverage   51.20%   70.74%   +19.53%     
===========================================
  Files          67        7       -60     
  Lines       13578      335    -13243     
===========================================
- Hits         6953      237     -6716     
+ Misses       5972       78     -5894     
+ Partials      653       20      -633     

see 62 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aolfat aolfat temporarily deployed to Deployment August 3, 2023 00:58 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Deployment August 3, 2023 00:58 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Deployment August 3, 2023 00:58 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Deployment August 3, 2023 00:58 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Deployment August 3, 2023 00:58 — with GitHub Actions Inactive
@aolfat aolfat changed the title Bugfix. KCF doesn't read csv files Bugfix: KCF doesn't read csv files feature registered on source Aug 4, 2023
@aolfat aolfat marked this pull request as ready for review August 4, 2023 00:07
@aolfat aolfat temporarily deployed to Integration testing August 4, 2023 00:09 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 4, 2023 00:09 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 4, 2023 00:09 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 4, 2023 00:09 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 4, 2023 00:09 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 4, 2023 16:48 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 4, 2023 16:48 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 4, 2023 16:48 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 4, 2023 16:48 — with GitHub Actions Inactive
@aolfat aolfat temporarily deployed to Integration testing August 4, 2023 16:48 — with GitHub Actions Inactive
@sdreyer sdreyer merged commit 9b45314 into main Aug 4, 2023
47 of 49 checks passed
@sdreyer sdreyer deleted the bugfix/read_csv_files_for_kcf branch August 4, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants