Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Storage Pathing (Azure Blob Storage) #947

Merged
merged 22 commits into from
Aug 17, 2023
Merged

Conversation

epps
Copy link
Contributor

@epps epps commented Aug 5, 2023

Description

This PR addresses issues around how we handle paths in cloud storage (e.g. Azure Blob Storage) and begins to extend the use of the Filepath interface to address these issues. There remains much work to do to fully harden the code base to pathing error, for example:

  • refactor store methods that construct paths based on IDs (e.g. PathWithPrefix)
  • document and cover all cases that could result in pathing issues (i.e. for S3 and GCS)
  • begin to standardize how the code base handles paths (e.g. root_path1 param in the client)

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@epps epps had a problem deploying to Integration testing August 5, 2023 14:06 — with GitHub Actions Failure
@epps epps had a problem deploying to Integration testing August 5, 2023 14:06 — with GitHub Actions Failure
@epps epps temporarily deployed to Integration testing August 5, 2023 14:06 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing August 5, 2023 14:06 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing August 5, 2023 14:06 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing August 5, 2023 14:06 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@78aad82). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #947   +/-   ##
=======================================
  Coverage        ?   70.74%           
=======================================
  Files           ?        7           
  Lines           ?      335           
  Branches        ?        0           
=======================================
  Hits            ?      237           
  Misses          ?       78           
  Partials        ?       20           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

serving/serving.go Outdated Show resolved Hide resolved
@epps epps had a problem deploying to Integration testing August 5, 2023 14:09 — with GitHub Actions Failure
provider/filepath.go Outdated Show resolved Hide resolved
serving/serving.go Outdated Show resolved Hide resolved
serving/serving.go Outdated Show resolved Hide resolved
provider/filepath.go Outdated Show resolved Hide resolved
provider/k8s.go Outdated Show resolved Hide resolved
provider/k8s.go Outdated Show resolved Hide resolved
provider/spark.go Outdated Show resolved Hide resolved
@epps epps temporarily deployed to Deployment August 7, 2023 16:25 — with GitHub Actions Inactive
@epps epps temporarily deployed to Deployment August 7, 2023 16:25 — with GitHub Actions Inactive
@epps epps temporarily deployed to Deployment August 7, 2023 16:25 — with GitHub Actions Inactive
@epps epps temporarily deployed to Deployment August 7, 2023 16:25 — with GitHub Actions Inactive
@epps epps temporarily deployed to Deployment August 7, 2023 16:25 — with GitHub Actions Inactive
@epps epps temporarily deployed to Deployment August 7, 2023 16:25 — with GitHub Actions Inactive
@epps epps temporarily deployed to Deployment August 7, 2023 16:25 — with GitHub Actions Inactive
@epps epps temporarily deployed to Deployment August 7, 2023 16:25 — with GitHub Actions Inactive
@epps epps temporarily deployed to Deployment August 7, 2023 16:25 — with GitHub Actions Inactive
@epps epps temporarily deployed to Deployment August 7, 2023 16:25 — with GitHub Actions Inactive
@epps epps temporarily deployed to Deployment August 7, 2023 16:25 — with GitHub Actions Inactive
@epps epps had a problem deploying to Integration testing August 7, 2023 16:27 — with GitHub Actions Failure
@epps epps had a problem deploying to Integration testing August 7, 2023 16:27 — with GitHub Actions Failure
@epps epps temporarily deployed to Integration testing August 7, 2023 16:27 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing August 7, 2023 16:27 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing August 7, 2023 16:27 — with GitHub Actions Inactive
@epps epps temporarily deployed to Integration testing August 7, 2023 16:28 — with GitHub Actions Inactive
@epps epps force-pushed the bug/cloud-file-store-pathing branch from 847209a to 00ab457 Compare August 17, 2023 22:18
@epps epps had a problem deploying to Integration testing August 17, 2023 22:23 — with GitHub Actions Failure
@epps epps had a problem deploying to Integration testing August 17, 2023 22:23 — with GitHub Actions Failure
@epps epps had a problem deploying to Integration testing August 17, 2023 22:23 — with GitHub Actions Failure
@epps epps temporarily deployed to Integration testing August 17, 2023 22:23 — with GitHub Actions Inactive
@epps epps had a problem deploying to Integration testing August 17, 2023 22:23 — with GitHub Actions Failure
@epps epps temporarily deployed to Integration testing August 17, 2023 22:23 — with GitHub Actions Inactive
@epps epps had a problem deploying to Integration testing August 17, 2023 22:24 — with GitHub Actions Failure
@epps epps merged commit 373246b into main Aug 17, 2023
44 of 49 checks passed
@epps epps deleted the bug/cloud-file-store-pathing branch August 17, 2023 22:26
sdreyer pushed a commit that referenced this pull request Aug 17, 2023
Co-authored-by: ahmadnazeri <42309296+ahmadnazeri@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants