-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud Storage Pathing (Azure Blob Storage) #947
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epps
had a problem deploying
to
Integration testing
August 5, 2023 14:06
— with
GitHub Actions
Failure
epps
had a problem deploying
to
Integration testing
August 5, 2023 14:06
— with
GitHub Actions
Failure
epps
temporarily deployed
to
Integration testing
August 5, 2023 14:06
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
August 5, 2023 14:06
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
August 5, 2023 14:06
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
August 5, 2023 14:06
— with
GitHub Actions
Inactive
Codecov Report
@@ Coverage Diff @@
## main #947 +/- ##
=======================================
Coverage ? 70.74%
=======================================
Files ? 7
Lines ? 335
Branches ? 0
=======================================
Hits ? 237
Misses ? 78
Partials ? 20 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
epps
commented
Aug 5, 2023
epps
had a problem deploying
to
Integration testing
August 5, 2023 14:09
— with
GitHub Actions
Failure
sdreyer
reviewed
Aug 6, 2023
epps
had a problem deploying
to
Integration testing
August 7, 2023 16:27
— with
GitHub Actions
Failure
epps
had a problem deploying
to
Integration testing
August 7, 2023 16:27
— with
GitHub Actions
Failure
epps
temporarily deployed
to
Integration testing
August 7, 2023 16:27
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
August 7, 2023 16:27
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
August 7, 2023 16:27
— with
GitHub Actions
Inactive
epps
temporarily deployed
to
Integration testing
August 7, 2023 16:28
— with
GitHub Actions
Inactive
… now be the complete path
…kwards compatibility
epps
force-pushed
the
bug/cloud-file-store-pathing
branch
from
August 17, 2023 22:18
847209a
to
00ab457
Compare
sdreyer
approved these changes
Aug 17, 2023
epps
had a problem deploying
to
Integration testing
August 17, 2023 22:23
— with
GitHub Actions
Failure
epps
had a problem deploying
to
Integration testing
August 17, 2023 22:23
— with
GitHub Actions
Failure
epps
had a problem deploying
to
Integration testing
August 17, 2023 22:23
— with
GitHub Actions
Failure
epps
temporarily deployed
to
Integration testing
August 17, 2023 22:23
— with
GitHub Actions
Inactive
epps
had a problem deploying
to
Integration testing
August 17, 2023 22:23
— with
GitHub Actions
Failure
epps
temporarily deployed
to
Integration testing
August 17, 2023 22:23
— with
GitHub Actions
Inactive
epps
had a problem deploying
to
Integration testing
August 17, 2023 22:24
— with
GitHub Actions
Failure
sdreyer
pushed a commit
that referenced
this pull request
Aug 17, 2023
Co-authored-by: ahmadnazeri <42309296+ahmadnazeri@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issues around how we handle paths in cloud storage (e.g. Azure Blob Storage) and begins to extend the use of the
Filepath
interface to address these issues. There remains much work to do to fully harden the code base to pathing error, for example:PathWithPrefix
)root_path1
param in the client)Type of change
Does this correspond to an open issue?
Select type(s) of change
Checklist: