Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider Config Testing #64 #948

Merged
merged 20 commits into from
Aug 10, 2023
Merged

Provider Config Testing #64 #948

merged 20 commits into from
Aug 10, 2023

Conversation

anthonylasso
Copy link
Contributor

@anthonylasso anthonylasso commented Aug 8, 2023

Description

This PR creates provider configuration test files that check both the Python and Golang Implementations.
The 2 files (provider_config_.test.py + provider_config_test.go) both use connection_configs.json as the source of truth for comparisons and instantiating provider types.

If a new provider is added, tests on both side will fail and notify the dev.
Should there be a schema mismatch, at least one file will throw an exception.

python
Screenshot 2023-08-07 at 7 11 35 PM

golang

Screenshot 2023-08-08 at 3 51 08 PM

schema mismatch exceptions

Screenshot 2023-08-09 at 11 52 17 AM

"successful" build failure

Screenshot 2023-08-09 at 12 06 20 PM

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

the config list test will fail if any new configs are added without also adding an associated test
@anthonylasso anthonylasso temporarily deployed to Integration testing August 8, 2023 00:19 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 8, 2023 00:19 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 8, 2023 00:19 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 8, 2023 00:19 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #948 (104e7bf) into main (dadd2e0) will increase coverage by 5.83%.
Report is 25 commits behind head on main.
The diff coverage is 52.96%.

@@            Coverage Diff             @@
##             main     #948      +/-   ##
==========================================
+ Coverage   51.20%   57.04%   +5.83%     
==========================================
  Files          67      104      +37     
  Lines       13578    18942    +5364     
==========================================
+ Hits         6953    10805    +3852     
- Misses       5972     7357    +1385     
- Partials      653      780     +127     
Files Changed Coverage Δ
client/src/featureform/cli.py 46.92% <0.00%> (ø)
provider/filestore.go 24.20% <0.00%> (-0.57%) ⬇️
provider/k8s.go 9.44% <0.00%> (+7.37%) ⬆️
provider/online.go 95.74% <ø> (ø)
provider/provider_type/provider_type.go 100.00% <ø> (ø)
client/src/featureform/dashboard_metadata.py 19.86% <9.70%> (ø)
client/src/featureform/resources.py 70.37% <44.44%> (ø)
client/src/featureform/serving.py 52.94% <56.25%> (ø)
client/src/featureform/sqlite_metadata.py 88.30% <58.33%> (ø)
client/src/featureform/client.py 62.85% <66.66%> (ø)
... and 13 more

... and 32 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anthonylasso anthonylasso temporarily deployed to Integration testing August 8, 2023 17:21 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 8, 2023 17:21 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 8, 2023 17:21 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 8, 2023 17:21 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 8, 2023 20:57 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 8, 2023 20:57 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 8, 2023 20:57 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 8, 2023 20:57 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 9, 2023 19:48 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 9, 2023 19:48 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 9, 2023 19:48 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 9, 2023 19:48 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 9, 2023 19:49 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 10, 2023 15:21 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 10, 2023 15:21 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 10, 2023 15:21 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 10, 2023 15:21 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 10, 2023 15:21 — with GitHub Actions Inactive
@anthonylasso anthonylasso merged commit d0a114d into main Aug 10, 2023
47 of 50 checks passed
@anthonylasso anthonylasso deleted the feature/provider/unittests branch August 10, 2023 17:35
sdreyer pushed a commit that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants