Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Get" Provider Testing #954

Merged
merged 9 commits into from
Aug 14, 2023
Merged

"Get" Provider Testing #954

merged 9 commits into from
Aug 14, 2023

Conversation

anthonylasso
Copy link
Contributor

@anthonylasso anthonylasso commented Aug 11, 2023

Description

This PR adds test coverage to the various "get" methods in register.py

It increases the register.py coverage by 7%, and total repo coverage by 1%.

Is related to issue enterprise-#62

Passing tests
Screenshot 2023-08-11 at 2 26 05 PM

register.py coverage increase

PR 59%
Screenshot 2023-08-11 at 2 43 11 PM

Main 52%
Screenshot 2023-08-11 at 2 43 01 PM

repo coverage increase

PR 56%
Screenshot 2023-08-11 at 2 50 21 PM

Main 55%
Screenshot 2023-08-11 at 2 49 33 PM

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@anthonylasso anthonylasso temporarily deployed to Integration testing August 11, 2023 19:37 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 11, 2023 19:37 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 11, 2023 19:37 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 11, 2023 19:37 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #954 (52716be) into main (8b73977) will increase coverage by 25.70%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #954       +/-   ##
===========================================
+ Coverage   45.04%   70.74%   +25.70%     
===========================================
  Files         107        7      -100     
  Lines       19187      335    -18852     
===========================================
- Hits         8643      237     -8406     
+ Misses       9934       78     -9856     
+ Partials      610       20      -590     

see 101 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anthonylasso anthonylasso marked this pull request as ready for review August 11, 2023 19:50
@anthonylasso anthonylasso temporarily deployed to Integration testing August 11, 2023 20:25 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 11, 2023 20:25 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 11, 2023 20:25 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 11, 2023 20:25 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 14, 2023 21:53 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 14, 2023 21:53 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 14, 2023 22:04 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 14, 2023 22:04 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 14, 2023 22:04 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 14, 2023 22:04 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 14, 2023 22:04 — with GitHub Actions Inactive
@anthonylasso anthonylasso merged commit 2c59a8a into main Aug 14, 2023
46 of 50 checks passed
@anthonylasso anthonylasso deleted the feature/getprovider/unittests branch August 14, 2023 22:11
sdreyer pushed a commit that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants