-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Get" Provider Testing #954
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #954 +/- ##
===========================================
+ Coverage 45.04% 70.74% +25.70%
===========================================
Files 107 7 -100
Lines 19187 335 -18852
===========================================
- Hits 8643 237 -8406
+ Misses 9934 78 -9856
+ Partials 610 20 -590 see 101 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sdreyer
approved these changes
Aug 14, 2023
aolfat
reviewed
Aug 14, 2023
aolfat
reviewed
Aug 14, 2023
aolfat
reviewed
Aug 14, 2023
sdreyer
pushed a commit
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds test coverage to the various "get" methods in
register.py
It increases the
register.py
coverage by 7%, and total repo coverage by 1%.Is related to issue enterprise-#62
Passing tests
register.py coverage increase
PR 59%
![Screenshot 2023-08-11 at 2 43 11 PM](https://private-user-images.githubusercontent.com/34227093/260137298-0cf0e0d7-e532-4eb9-ba72-15da7ad18f3a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTgyNjEzMTAsIm5iZiI6MTcxODI2MTAxMCwicGF0aCI6Ii8zNDIyNzA5My8yNjAxMzcyOTgtMGNmMGUwZDctZTUzMi00ZWI5LWJhNzItMTVkYTdhZDE4ZjNhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjEzVDA2NDMzMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc5ZjQ0ODFjY2M3M2NlOTliODI3ZjlmMGM2Y2E4ZjkzOGRkM2M2ZTQ3NDNjYTBhNjViNTcwMjg5MDM0OTg2OWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.lcLJtED4vlc2h8p9vIC1W5RUb6KVMZ2RvW295EZ_S3A)
Main 52%
![Screenshot 2023-08-11 at 2 43 01 PM](https://private-user-images.githubusercontent.com/34227093/260137152-aa0f32c0-9b7b-4b7f-99e5-b62727b9b877.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTgyNjEzMTAsIm5iZiI6MTcxODI2MTAxMCwicGF0aCI6Ii8zNDIyNzA5My8yNjAxMzcxNTItYWEwZjMyYzAtOWI3Yi00YjdmLTk5ZTUtYjYyNzI3YjliODc3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjEzVDA2NDMzMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ3Nzc2MmY0Y2RiMWE3Y2U5Zjk3YmYxZjA3MjFhODM4ZGJiMzYyNDZjMGIzNWNkNzY2ZWQzMWQyNmIxNmUyNDYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.CCvA6HA5SJm7_zLkD05HBhfcCoYYJJn49zoX3tfpHB8)
repo coverage increase
PR 56%
![Screenshot 2023-08-11 at 2 50 21 PM](https://private-user-images.githubusercontent.com/34227093/260138666-7d2a6c52-40aa-4a64-9222-4b748022eae8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTgyNjEzMTAsIm5iZiI6MTcxODI2MTAxMCwicGF0aCI6Ii8zNDIyNzA5My8yNjAxMzg2NjYtN2QyYTZjNTItNDBhYS00YTY0LTkyMjItNGI3NDgwMjJlYWU4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjEzVDA2NDMzMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdjMTYwZDdiODgxMTM1MTVlMmIxOTM1OGNiNTZkYzVmMGQxMTRjYjYxY2U0OGFkOGM4NDdjOWE1M2QxNTk1NDkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.5BD_es1CG4b1vBpPtQ-LZOIM82oQ7e5fDI16kAzgrIs)
Main 55%
![Screenshot 2023-08-11 at 2 49 33 PM](https://private-user-images.githubusercontent.com/34227093/260138674-0e2c5b47-d56d-46c7-9c4a-9f929216b48f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTgyNjEzMTAsIm5iZiI6MTcxODI2MTAxMCwicGF0aCI6Ii8zNDIyNzA5My8yNjAxMzg2NzQtMGUyYzViNDctZDU2ZC00NmM3LTljNGEtOWY5MjkyMTZiNDhmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjEzVDA2NDMzMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQyMmNkN2M1ZDJiOTE5Y2U3NGRhNzQ2OTNmMzk2ZDk0ZDNjN2NlNzQ5YzNkMTI3ZjJjZTMzZmJjNDEwZDYzMGEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.o1RmQTu5PoUO7IH6b536y2GMC4Mu7M5RUbKuR7swj-o)
Type of change
Does this correspond to an open issue?
Select type(s) of change
Checklist: