Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spark Tests #958

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Spark Tests #958

merged 2 commits into from
Aug 16, 2023

Conversation

sdreyer
Copy link
Collaborator

@sdreyer sdreyer commented Aug 14, 2023

Description

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@sdreyer sdreyer temporarily deployed to Integration testing August 14, 2023 02:33 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 14, 2023 02:33 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 14, 2023 02:33 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #958 (d98455e) into main (d0a114d) will increase coverage by 1.82%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #958      +/-   ##
==========================================
+ Coverage   57.22%   59.05%   +1.82%     
==========================================
  Files         107      107              
  Lines       19187    19189       +2     
==========================================
+ Hits        10980    11332     +352     
+ Misses       7396     7052     -344     
+ Partials      811      805       -6     
Files Changed Coverage Δ
provider/filestore.go 41.81% <100.00%> (+2.32%) ⬆️
provider/spark.go 50.39% <100.00%> (+27.27%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sdreyer sdreyer temporarily deployed to Integration testing August 14, 2023 04:02 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 14, 2023 04:02 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 14, 2023 04:02 — with GitHub Actions Inactive
Copy link
Contributor

@ahmadnazeri ahmadnazeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; just one question.

provider/spark_test.go Outdated Show resolved Hide resolved
@sdreyer sdreyer marked this pull request as ready for review August 16, 2023 21:32
@sdreyer sdreyer merged commit 691d616 into main Aug 16, 2023
15 of 16 checks passed
@sdreyer sdreyer deleted the tests/spark branch August 16, 2023 21:32
@sdreyer sdreyer temporarily deployed to Integration testing August 16, 2023 21:33 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 16, 2023 21:33 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 16, 2023 21:33 — with GitHub Actions Inactive
sdreyer added a commit that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants