Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register instantiate tests #961

Merged
merged 15 commits into from
Aug 16, 2023
Merged

Conversation

anthonylasso
Copy link
Contributor

@anthonylasso anthonylasso commented Aug 15, 2023

Description

This PR adds test coverage to the "register" methods in register.py

register.py coverage is increased from 58% -> 65%

Relates to issue enterprise-#63

New Tests
Screenshot 2023-08-15 at 11 55 24 AM

register.py coverage

PR 65%
Screenshot 2023-08-15 at 11 49 31 AM

Main 58%
Screenshot 2023-08-15 at 11 49 40 AM

total repo coverage

PR 58%
Screenshot 2023-08-15 at 11 50 07 AM

Main 56%
Screenshot 2023-08-15 at 11 50 13 AM

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@anthonylasso anthonylasso temporarily deployed to Integration testing August 15, 2023 16:59 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 15, 2023 16:59 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 15, 2023 16:59 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 15, 2023 16:59 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 15, 2023 16:59 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #961 (c4ed165) into main (2bd119f) will decrease coverage by 0.50%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #961      +/-   ##
==========================================
- Coverage   57.18%   56.68%   -0.50%     
==========================================
  Files          72      107      +35     
  Lines       14153    19153    +5000     
==========================================
+ Hits         8093    10857    +2764     
- Misses       5249     7539    +2290     
+ Partials      811      757      -54     
Files Changed Coverage Δ
client/src/featureform/register.py 64.79% <100.00%> (ø)

... and 41 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anthonylasso anthonylasso temporarily deployed to Integration testing August 16, 2023 17:38 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 16, 2023 17:38 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 16, 2023 17:38 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 16, 2023 17:38 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 16, 2023 17:38 — with GitHub Actions Inactive
@anthonylasso anthonylasso merged commit 7806b2d into main Aug 16, 2023
15 of 16 checks passed
@anthonylasso anthonylasso deleted the feature/registerprovider/unittests branch August 16, 2023 19:48
@anthonylasso anthonylasso temporarily deployed to Integration testing August 16, 2023 19:52 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 16, 2023 19:52 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 16, 2023 19:52 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 16, 2023 19:52 — with GitHub Actions Inactive
@anthonylasso anthonylasso temporarily deployed to Integration testing August 16, 2023 19:52 — with GitHub Actions Inactive
@anthonylasso anthonylasso restored the feature/registerprovider/unittests branch August 16, 2023 22:34
sdreyer pushed a commit that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants