Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: PostgreSQL: adding support for ssl mode #964

Merged
merged 12 commits into from
Aug 17, 2023

Conversation

ahmadnazeri
Copy link
Contributor

@ahmadnazeri ahmadnazeri commented Aug 16, 2023

Description

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing August 16, 2023 17:57 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing August 16, 2023 17:57 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing August 16, 2023 17:57 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #964 (1a0c425) into main (6e168d1) will increase coverage by 1.81%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #964      +/-   ##
==========================================
+ Coverage   59.17%   60.98%   +1.81%     
==========================================
  Files         107      107              
  Lines       19192    19194       +2     
==========================================
+ Hits        11356    11705     +349     
+ Misses       7063     6655     -408     
- Partials      773      834      +61     
Files Changed Coverage Δ
client/src/featureform/register.py 64.85% <ø> (ø)
client/src/featureform/type_objects.py 58.69% <ø> (ø)
client/src/featureform/resources.py 74.44% <100.00%> (+0.02%) ⬆️
provider/postgres.go 79.16% <100.00%> (ø)
provider/provider_config/postgres_config.go 90.00% <100.00%> (+0.52%) ⬆️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

client/src/featureform/register.py Show resolved Hide resolved
@ahmadnazeri ahmadnazeri marked this pull request as ready for review August 16, 2023 23:36
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing August 16, 2023 23:37 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing August 17, 2023 17:19 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing August 17, 2023 17:19 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing August 17, 2023 17:19 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing August 17, 2023 17:38 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing August 17, 2023 17:38 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing August 17, 2023 17:38 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing August 17, 2023 17:38 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing August 17, 2023 17:59 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing August 17, 2023 17:59 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing August 17, 2023 17:59 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing August 17, 2023 17:59 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing August 17, 2023 18:45 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing August 17, 2023 18:45 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing August 17, 2023 18:46 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing August 17, 2023 18:46 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri temporarily deployed to Integration testing August 17, 2023 18:46 — with GitHub Actions Inactive
@ahmadnazeri ahmadnazeri merged commit 00de8c6 into main Aug 17, 2023
47 of 49 checks passed
@ahmadnazeri ahmadnazeri deleted the feature/support_postgres_ssl_mode branch August 17, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants