Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests/spark #965

Merged
merged 10 commits into from
Aug 17, 2023
Merged

Tests/spark #965

merged 10 commits into from
Aug 17, 2023

Conversation

sdreyer
Copy link
Collaborator

@sdreyer sdreyer commented Aug 16, 2023

Description

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@sdreyer sdreyer temporarily deployed to Integration testing August 16, 2023 23:52 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 16, 2023 23:52 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 16, 2023 23:52 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 16, 2023 23:52 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #965 (36b01e3) into main (691d616) will increase coverage by 3.59%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main     #965      +/-   ##
==========================================
+ Coverage   55.61%   59.20%   +3.59%     
==========================================
  Files         107      107              
  Lines       19183    19188       +5     
==========================================
+ Hits        10668    11361     +693     
+ Misses       7790     7057     -733     
- Partials      725      770      +45     
Files Changed Coverage Δ
client/src/featureform/type_objects.py 56.81% <0.00%> (-1.33%) ⬇️
provider/filestore.go 26.63% <100.00%> (-15.19%) ⬇️
provider/spark.go 50.39% <100.00%> (ø)

... and 18 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sdreyer sdreyer temporarily deployed to Integration testing August 17, 2023 00:14 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 17, 2023 00:14 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 17, 2023 00:14 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 17, 2023 00:15 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 17, 2023 14:50 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 17, 2023 14:51 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 17, 2023 14:51 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 17, 2023 14:51 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 17, 2023 14:51 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 17, 2023 15:03 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 17, 2023 15:47 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 17, 2023 16:07 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 17, 2023 16:07 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 17, 2023 16:07 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 17, 2023 16:07 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 17, 2023 16:07 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 17, 2023 16:28 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 17, 2023 16:28 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 17, 2023 16:28 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 17, 2023 16:28 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 17, 2023 16:28 — with GitHub Actions Inactive
@sdreyer sdreyer marked this pull request as ready for review August 17, 2023 17:07
@sdreyer sdreyer merged commit 6e168d1 into main Aug 17, 2023
14 of 15 checks passed
@sdreyer sdreyer deleted the tests/spark branch August 17, 2023 17:08
@sdreyer sdreyer temporarily deployed to Integration testing August 17, 2023 17:09 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 17, 2023 17:09 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 17, 2023 17:09 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 17, 2023 17:09 — with GitHub Actions Inactive
@sdreyer sdreyer temporarily deployed to Integration testing August 17, 2023 17:09 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants