Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refreshing API keys still allows connections in with invalidated key until restart #998

Closed
1 of 5 tasks
amandam11 opened this issue May 15, 2023 · 0 comments · Fixed by #999
Closed
1 of 5 tasks

Comments

@amandam11
Copy link

Describe the bug
I am using the party-server Dockerfile to start FeatureHub.
If I connect using the nodeJS client with a service account client key, then all is good.
If I then use the "Reset client eval API keys" a new key is generated and visible.
However, my client stays connected using the old key, and they can receive updates to any feature hub values. If I restart my client, it also manages to connect with the old client key.

If I then restart FeatureHub, and then my client, then the client is now refused as it says the key is not valid.

However, if instead of reseting the keys, I removed the permisssions from the service account - then I find my client is kicked out. If I then, refresh the keys and give back the service account permission, I find the client cannot connect with the old key, only the new key (which is good).

It appears as if the cache of valid keys to use is not invalidated when I just use the reset client key, only if I remove permissions from the account first.

Which area does this issue belong to?

  • FeatureHub Admin Web app
  • SDK
  • SDK examples
  • Documentation
  • Other (Core)

To Reproduce
Steps to reproduce the behavior:

  1. Have a client connected with a service account's valid client key
  2. Go to 'Service Account'
  3. Click on 'Reset client eval API keys'
  4. Success returned, but client stays connected

Expected behavior
Client connection to be invalidated, next time it gets refreshed.

Screenshots
N/A

Versions

  • FeatureHub version 1.6.0
  • SDK version [featurehub-javascript-node-sdk v1.2.0 and v1.3.0]
  • OS: [Docker image featurehub/party-server, Docker version 23.0.6, Ubuntu 20.04]
  • Browser [Chrome]

You can get the version of the FeatureHub container by running docker ps command.
Please include the OS and what version of the OS and Docker you're running.

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant