Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes registration URL issues and nav tabbing issues #141

Merged
merged 5 commits into from
Aug 2, 2020

Conversation

rvowles
Copy link
Contributor

@rvowles rvowles commented Aug 1, 2020

Description

This fixes the issue where you cannot re-get the registration URL. It also makes the registration URL dependent on whether local login is enabled. It also lets the token be refreshed which wasn't possible before and also fixes the nav issue with the tabs for applicaction.

Fixes #13 #136 #98

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

pom.xml Outdated Show resolved Hide resolved
@rvowles rvowles merged commit b923b5e into master Aug 2, 2020
@rvowles rvowles deleted the bugfix/issue-13 branch August 6, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USER FEEDBACK: Tabs perhaps confusing Registration URL issue Get registration url after user created
2 participants