fixed head printout and flight demo index #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This all looks good to me |
Seth-Rothschild
added a commit
that referenced
this pull request
Sep 5, 2018
Seth-Rothschild
added a commit
that referenced
this pull request
Sep 24, 2018
kmax12
pushed a commit
that referenced
this pull request
Sep 28, 2018
* revise handling time page * add mock customer cutoff time * add approximate to handling time page * standardize way entityset, cutoff_time, DFS are used * add Mock customer example prior to flight * add date_of_birth to mock_customer * finish draft #2 * restructure to do all time index pars first, cts second * reference an "active" session in lti section * draft images for handling_time * use updated mock_customer customer time_index in test * Re-order sections * minor phrasing changes * update section titles * add cutoff_times df differently * modify paragraph explaining nonunique cutoff time choice * Update handling_time.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the flight fix:
storage_options={'anon': True}to fix s3 issue with public files and daskdf = df.reset_index(drop=True)is there because the dataframe is read in parallel with dask, and the index needs to be reset since these values are used to create thetrip_idFor the head fix:
headfunction ofentityset. This is fixed by calling head on theentitywhich usesself.df.headto get the values.cutoff_timefor head is not implemented yet.