New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed head printout and flight demo index #2

Merged
merged 1 commit into from Sep 22, 2017

Conversation

Projects
None yet
2 participants
@gsheni
Contributor

gsheni commented Sep 21, 2017

For the flight fix:

  • addedstorage_options={'anon': True} to fix s3 issue with public files and dask
  • df = df.reset_index(drop=True) is there because the dataframe is read in parallel with dask, and the index needs to be reset since these values are used to create the trip_id

For the head fix:

  • there was a circular call in the head function of entityset. This is fixed by calling head on the entity which uses self.df.head to get the values.
  • cutoff_time for head is not implemented yet.
@kmax12

This comment has been minimized.

Member

kmax12 commented Sep 22, 2017

This all looks good to me

@kmax12 kmax12 merged commit 9bfcf12 into master Sep 22, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@kmax12 kmax12 deleted the head_and_flight_fix branch Sep 25, 2017

Seth-Rothschild added a commit that referenced this pull request Sep 5, 2018

Seth-Rothschild added a commit that referenced this pull request Sep 24, 2018

kmax12 added a commit that referenced this pull request Sep 28, 2018

Handling time rewrite (#245)
* revise handling time page

* add mock customer cutoff time

* add approximate to handling time page

* standardize way entityset, cutoff_time, DFS are used

* add Mock customer example prior to flight

* add date_of_birth to mock_customer

* finish draft #2

* restructure to do all time index pars first, cts second

* reference an "active" session in lti section

* draft images for handling_time

* use updated mock_customer customer time_index in test

* Re-order sections

* minor phrasing changes

* update section titles

* add cutoff_times df differently

* modify paragraph explaining nonunique cutoff time choice

* Update handling_time.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment